Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] Prepare the 1.24.0 beta release #47119

Merged
merged 3 commits into from
Jan 2, 2018
Merged

Conversation

alexcrichton
Copy link
Member

  • Update the channel of this release
  • Update the bootstrap compiler to the dev artifacts
  • Fix compile for last-minute backports

* Update the channel of this release
* Update the bootstrap compiler to the dev artifacts
* Fix compile for last-minute backports
@alexcrichton
Copy link
Member Author

@bors: r+ p=10

@bors
Copy link
Contributor

bors commented Jan 2, 2018

📌 Commit e2e9751 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jan 2, 2018

⌛ Testing commit e2e9751 with merge a74cf7d...

bors added a commit that referenced this pull request Jan 2, 2018
[beta] Prepare the 1.24.0 beta release

* Update the channel of this release
* Update the bootstrap compiler to the dev artifacts
* Fix compile for last-minute backports
@bors
Copy link
Contributor

bors commented Jan 2, 2018

💔 Test failed - status-travis

I believe this was forgotten from rust-lang#45191 but hopefully is a simple fix!
@alexcrichton
Copy link
Member Author

@bors: r+

@bors
Copy link
Contributor

bors commented Jan 2, 2018

📌 Commit d5c7ba8 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jan 2, 2018

⌛ Testing commit d5c7ba8 with merge 1e52eb96d55a615b46be3840a3f5f49459d56802...

@bors
Copy link
Contributor

bors commented Jan 2, 2018

💔 Test failed - status-travis

@kennytm
Copy link
Member

kennytm commented Jan 2, 2018

miri and clippy needs to be test-pass in beta/stable. They are currently build-fail.

@kennytm kennytm added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Jan 2, 2018
@alexcrichton
Copy link
Member Author

@kennytm ah ok, so for those two tools I don't think we're ready to commit to them working, so could a patch be prepared for master which omits them from the "required to pass on beta" check?

For now I've pushed up a "hack" commit which can't be cherry-picked but should solve the problem

@bors: r+

@bors
Copy link
Contributor

bors commented Jan 2, 2018

📌 Commit 95d5e31 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jan 2, 2018

⌛ Testing commit 95d5e31 with merge 5b496b7...

bors added a commit that referenced this pull request Jan 2, 2018
[beta] Prepare the 1.24.0 beta release

* Update the channel of this release
* Update the bootstrap compiler to the dev artifacts
* Fix compile for last-minute backports
@bors
Copy link
Contributor

bors commented Jan 2, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 5b496b7 to beta...

@bors bors merged commit 95d5e31 into rust-lang:beta Jan 2, 2018
@kennytm kennytm mentioned this pull request Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-blocked Status: Blocked on something else such as an RFC or other implementation work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants