impl From<bool> for AtomicBool #46293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @TimNN (rust_highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
added
the
beta-nominated
|
Marked as beta nominated. cc @rust-lang/libs -- what do you think about backporting this to beta? |
|
I don't really see any reason to backport this. |
kennytm
added
S-waiting-on-review
|
Agreed that feature-wise this seems fine but I probably wouldn't do the backport |
|
Right, I've changed it to |
kennytm
removed
the
beta-nominated
|
LGTM. @bors r+ |
|
📌 Commit 71d766b has been approved by |
|
@bors rollup |
Mark-Simulacrum
added
S-waiting-on-bors
|
⌛ Testing commit 71d766b with merge 736976d701b620831b0617661bdc0ef0e953b21a... |
|
@bors treeclosed=1 Something's wrong with the macOS CI, investigating. |
|
💔 Test failed - status-travis |
|
@bors retry — travis-ci/travis-ci#8821 |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Nov 29, 2017
impl From<bool> for AtomicBool This seems like an obvious omission from rust-lang#45610. ~~I've used the same feature name and version in the hope that this can be backported to beta so it's stabilized with the other impls. If it can't be I'll change it to `1.24.0`.~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like an obvious omission from #45610.
I've used the same feature name and version in the hope that this can be backported to beta so it's stabilized with the other impls. If it can't be I'll change it to1.24.0.