Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl From<T> for AtomicT #45610

Merged
merged 3 commits into from
Nov 4, 2017
Merged

impl From<T> for AtomicT #45610

merged 3 commits into from
Nov 4, 2017

Conversation

strake
Copy link
Contributor

@strake strake commented Oct 29, 2017

No description provided.

@kennytm kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Oct 29, 2017
@strake strake force-pushed the atomic_from branch 2 times, most recently from 17b9cc1 to 5c21637 Compare October 29, 2017 09:33
nagisa
nagisa reviewed Oct 29, 2017
View reviewed changes
src/libcore/sync/atomic.rs Outdated
@@ -927,6 +927,12 @@ impl<T> AtomicPtr<T> {
}
}

#[stable(feature = "rust1", since = "1.0.0")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong as it implies the implementation has existed since 1.0.0. You need to make a new stable feature.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, that makes sense now — it complained about (feature = "rust1", since = "1.22.0").

nagisa
nagisa reviewed Oct 29, 2017
View reviewed changes
src/libcore/sync/atomic.rs Outdated
@@ -967,6 +973,12 @@ macro_rules! atomic_int {
}
}

#[$stable]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly here.

@nagisa
Copy link
Member

nagisa commented Oct 31, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Oct 31, 2017

📌 Commit 80a3191 has been approved by nagisa

@nagisa
Copy link
Member

nagisa commented Oct 31, 2017

@bors r-

1.22.0 is current beta release, so this feature would release with 1.23 at the earliest. The version number should be changed to 1.23.

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2017
@kennytm
Copy link
Member

kennytm commented Nov 2, 2017

@bors r=nagisa

@bors
Copy link
Contributor

bors commented Nov 2, 2017

📌 Commit be21779 has been approved by nagisa

@kennytm kennytm added relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 2, 2017
@kennytm
Copy link
Member

kennytm commented Nov 2, 2017

@bors rollup

@bors
Copy link
Contributor

bors commented Nov 3, 2017

⌛ Testing commit be21779 with merge 0fb1b7cf5a4d6903348b8bd137a44419f9555cb3...

@bors
Copy link
Contributor

bors commented Nov 3, 2017

💔 Test failed - status-travis

@kennytm
Copy link
Member

kennytm commented Nov 3, 2017

@bors retry

kennytm added a commit to kennytm/rust that referenced this pull request Nov 4, 2017
@kennytm
Rollup merge of rust-lang#45610 - strake:atomic_from, r=nagisa
ae512c4 
impl From<T> for AtomicT
@kennytm kennytm mentioned this pull request Nov 4, 2017
Merged
bors added a commit that referenced this pull request Nov 4, 2017
@bors
Auto merge of #45755 - kennytm:rollup, r=kennytm
9acc333 
Rollup of 9 pull requests

- Successful merges: #45548, #45610, #45639, #45669, #45681, #45718, #45722, #45739, #45746
- Failed merges:
@bors bors merged commit be21779 into rust-lang:master Nov 4, 2017
@kennytm kennytm mentioned this pull request Nov 6, 2017
Closed
@ollie27 ollie27 mentioned this pull request Nov 27, 2017
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Nov 29, 2017
@kennytm
Rollup merge of rust-lang#46293 - ollie27:atomic_bool_from, r=BurntSushi
fc9abbd 
impl From<bool> for AtomicBool

This seems like an obvious omission from rust-lang#45610. ~~I've used the same feature name and version in the hope that this can be backported to beta so it's stabilized with the other impls. If it can't be I'll change it to `1.24.0`.~~
@ollie27 ollie27 mentioned this pull request Dec 27, 2017
Merged
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 4, 2018
@steveklabnik
Rollup merge of rust-lang#47030 - ollie27:stab, r=alexcrichton
b6f7484 
Correct a few stability attributes

* The extra impls for `ManuallyDrop` were added in rust-lang#44310 which was only stabilised in 1.22.0.
* The impls for `SliceIndex` were stabilised in rust-lang#43373 but as `RangeInclusive` and `RangeToInclusive` are still unstable the impls should remain unstable.
* The `From` impls for atomic integers were added in rust-lang#45610 but most atomic integers are still unstable.
* The `shared_from_slice2` impls were added in rust-lang#45990 but they won't be stable until 1.24.0.
* The `Mutex` and `RwLock` impls were added in rust-lang#46082 but won't be stable until 1.24.0.
kennytm added a commit to kennytm/rust that referenced this pull request Jan 4, 2018
@kennytm
Rollup merge of rust-lang#47030 - ollie27:stab, r=alexcrichton
f2d9035 
Correct a few stability attributes

* The extra impls for `ManuallyDrop` were added in rust-lang#44310 which was only stabilised in 1.22.0.
* The impls for `SliceIndex` were stabilised in rust-lang#43373 but as `RangeInclusive` and `RangeToInclusive` are still unstable the impls should remain unstable.
* The `From` impls for atomic integers were added in rust-lang#45610 but most atomic integers are still unstable.
* The `shared_from_slice2` impls were added in rust-lang#45990 but they won't be stable until 1.24.0.
* The `Mutex` and `RwLock` impls were added in rust-lang#46082 but won't be stable until 1.24.0.
kennytm added a commit to kennytm/rust that referenced this pull request Jan 5, 2018
@kennytm
Rollup merge of rust-lang#47030 - ollie27:stab, r=alexcrichton
63c8e0c 
Correct a few stability attributes

* The extra impls for `ManuallyDrop` were added in rust-lang#44310 which was only stabilised in 1.22.0.
* The impls for `SliceIndex` were stabilised in rust-lang#43373 but as `RangeInclusive` and `RangeToInclusive` are still unstable the impls should remain unstable.
* The `From` impls for atomic integers were added in rust-lang#45610 but most atomic integers are still unstable.
* The `shared_from_slice2` impls were added in rust-lang#45990 but they won't be stable until 1.24.0.
* The `Mutex` and `RwLock` impls were added in rust-lang#46082 but won't be stable until 1.24.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagisa nagisa nagisa left review comments

Assignees
No one assigned
Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@strake @nagisa @bors @kennytm