mir: don't attempt to promote Unpromotable constant temps. #33541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Aatch (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ |
|
📌 Commit e5a91b7 has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 12, 2016
mir: don't attempt to promote Unpromotable constant temps. Fixes rust-lang#33537. This was a non-problem in regular functions, but we also promote in `const fn`s. There we always qualify temps so you can't depend on `Unpromotable` temps being `NOT_CONST`.
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
May 12, 2016
mir: don't attempt to promote Unpromotable constant temps. Fixes rust-lang#33537. This was a non-problem in regular functions, but we also promote in `const fn`s. There we always qualify temps so you can't depend on `Unpromotable` temps being `NOT_CONST`.
|
@bors p=1 (unbreaks Servo) |
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
May 13, 2016
mir: don't attempt to promote Unpromotable constant temps. Fixes rust-lang#33537. This was a non-problem in regular functions, but we also promote in `const fn`s. There we always qualify temps so you can't depend on `Unpromotable` temps being `NOT_CONST`.
bors
added a commit
that referenced
this pull request
May 13, 2016
mir: don't attempt to promote Unpromotable constant temps. Fixes #33537. This was a non-problem in regular functions, but we also promote in `const fn`s. There we always qualify temps so you can't depend on `Unpromotable` temps being `NOT_CONST`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33537. This was a non-problem in regular functions, but we also promote in
const fns.There we always qualify temps so you can't depend on
Unpromotabletemps beingNOT_CONST.