Make --emit dep-info work correctly with -Z no-analysis again. #33450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
| { | ||
| let _ignore = hir_map.dep_graph.in_ignore(); | ||
| controller_entry_point!(after_write_deps, | ||
| controller_entry_point!(after_ast, |
There was a problem hiding this comment.
I think after_hir_lowering might be a better name here - ast is a data structure rather than a phase.
|
lgtm, r+ with the name changed |
|
@bors: r+ |
|
📌 Commit 5ec8e92 has been approved by |
|
⌛ Testing commit 5ec8e92 with merge 82f2240... |
|
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
|
Whoops, looks like my regex failed on Windows. Could you approve again? |
|
☔ The latest upstream changes (presumably #33443) made this pull request unmergeable. Please resolve the merge conflicts. |
Previously, it would attempt to resolve some external crates that weren't necessary for dep-info output. Fixes rust-lang#33231.
SiegeLord
force-pushed
the
dep_info_no_analysis
branch
from
8687aa8 to
ba04a52
Compare
|
Re-based onto master. |
|
@bors: r+ |
|
📌 Commit ba04a52 has been approved by |
|
|
⌛ Testing commit ba04a52 with merge 487dffe... |
|
@bors r- |
|
⛄ The build was interrupted to prioritize another pull request. |
|
::sigh:: this wouldn't be a problem if rustc didn't put the absolute path inside the deps file, which requires me to sed it away... |
|
I fixed the sed invocation to work with BSD utils, so should be ok to try this again. |
|
@bors r=nrc |
|
📌 Commit 215b260 has been approved by |
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
May 12, 2016
Make --emit dep-info work correctly with -Z no-analysis again. Previously, it would attempt to resolve some external crates that weren't necessary for dep-info output. Fixes rust-lang#33231.
bors
added a commit
that referenced
this pull request
May 13, 2016
Make --emit dep-info work correctly with -Z no-analysis again. Previously, it would attempt to resolve some external crates that weren't necessary for dep-info output. Fixes #33231.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it would attempt to resolve some external crates that weren't necessary for dep-info output.
Fixes #33231.