Abort configure if source path contains spaces, #18477 #29858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
fhahn
force-pushed
the
abort-if-path-has-spaces
branch
2 times, most recently
from
64876b7 to
535d486
Compare
|
r? @brson |
|
(I'm fine with this) |
fhahn
force-pushed
the
abort-if-path-has-spaces
branch
from
535d486 to
9612c9a
Compare
|
@brson I've updated the PR and removed the note in the README. Is there anything else I should change? |
|
@bors r+ |
|
📌 Commit 9612c9a has been approved by |
bors
added a commit
that referenced
this pull request
Dec 1, 2015
The Rust build scripts do work if the source directory contains spaces. I tried to make it work with spaces. I managed to get the Rust's and LLVM's configure scripts to work with spaces in the path, but I could not figure out how to get the Rust makefiles working. So for now, this PR updates Rust's `configure` to abort if the source path contains spaces. I also added a note about spaces in the source path to the README. I think this should close #18477 for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Rust build scripts do work if the source directory contains spaces. I tried to make it work with spaces. I managed to get the Rust's and LLVM's configure scripts to work with spaces in the path, but I could not figure out how to get the Rust makefiles working.
So for now, this PR updates Rust's
configureto abort if the source path contains spaces. I also added a note about spaces in the source path to the README.I think this should close #18477 for now.