Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

building on Windows: chokes on paths with spaces #18477

Closed
aturon opened this issue Oct 31, 2014 · 1 comment · Fixed by #29858
Closed

building on Windows: chokes on paths with spaces #18477

aturon opened this issue Oct 31, 2014 · 1 comment · Fixed by #29858

Comments

@aturon
Copy link
Member

aturon commented Oct 31, 2014

Following the installation instructions, if you happen to try to build rust in a directory with a space in the name ./configure chokes, claiming not to be able to find your target triple.
@aturon aturon added the A-build label Oct 31, 2014
@aturon
Copy link
Member Author

aturon commented Oct 31, 2014

At the least, we should put a warning about this in the installation instructions.

@fhahn fhahn mentioned this issue Nov 16, 2015
Merged
fhahn added a commit to fhahn/rust that referenced this issue Nov 16, 2015
@fhahn
Abort configure if source path contains spaces, closes rust-lang#18477
9612c9a
bors added a commit that referenced this issue Dec 1, 2015
@bors
Auto merge of #29858 - fhahn:abort-if-path-has-spaces, r=brson
69b2fce 
The Rust build scripts do work if the source directory contains spaces. I tried to make it work with spaces. I managed to get the Rust's and LLVM's configure scripts to work with spaces in the path, but I could not figure out how to get the Rust makefiles working.

So for now, this PR updates Rust's `configure` to abort if the source path contains spaces. I also added a note about spaces in the source path to the README.

I think this should close #18477 for now.
lnicola added a commit to lnicola/rust that referenced this issue Nov 12, 2024
@lnicola
Merge pull request rust-lang#18477 from lnicola/rm-ap-text-edit
56f46c2 
minor: Don't try to auto-publish text-edit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Abort configure if source path contains spaces, #18477 fhahn/rust
1 participant
@aturon