-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to LLVM 17.0.6 #118936
Update to LLVM 17.0.6 #118936
Conversation
|
This comment has been minimized.
This comment has been minimized.
Awesome, looks like LLVM updates are broken again. Failing assertion: rust/src/bootstrap/src/tests/config.rs Line 31 in 1a8afa0
|
Will backport to beta? llvm/llvm-project#75184 has been merged. |
There are a number of fixes here: * if-unchanged is supposed to be the default for channel=dev, but actually used different logic. Make sure it is the same. * If no llvm section was specified at all, different logic was also used. Go through the standard helper. * Some more assertions should depend on if_unchanged.
This PR modifies If appropriate, please update |
@DianQK Thanks, I have included the additional cherry-pick. |
Nominating for beta-backport as the cherry-pick includes a fix for #117902 |
@bors p=1 Fixes P-critical and I-unsound issue |
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (604f185): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 671.324s -> 670.068s (-0.19%) |
[beta] backports - temporarily revert "ice on ambguity in mir typeck" rust-lang#118736 - Update to LLVM 17.0.6 rust-lang#118936 r? ghost
[beta] backports - temporarily revert "ice on ambguity in mir typeck" rust-lang#118736 - Update to LLVM 17.0.6 rust-lang#118936 r? ghost
This is a rebase on the final LLVM 17 release.
Includes the RISCV fix requested in rust-lang/llvm-project#157 (and I think this is also the only change in this release that is relevant to rustc).
r? @cuviper
Fixes #117902