Backport rv32 SRLI fix #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've rebased our fork to the last LLVM 17 release, which includes this fix. The corresponding submodule update is at rust-lang/rust#118936. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 15, 2023
Update to LLVM 17.0.6 This is a rebase on the final LLVM 17 release. Includes the RISCV fix requested in rust-lang/llvm-project#157 (and I think this is also the only change in this release that is relevant to rustc). r? `@cuviper` Fixes rust-lang#117902
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Dec 15, 2023
Update to LLVM 17.0.6 This is a rebase on the final LLVM 17 release. Includes the RISCV fix requested in rust-lang/llvm-project#157 (and I think this is also the only change in this release that is relevant to rustc). r? `@cuviper` Fixes #117902
vext01
pushed a commit
to vext01/llvm-project
that referenced
this pull request
May 16, 2024
Unsupported binops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM 17 introduced this bug: llvm#69408 that generates an illegal instruction for rv32. This fix will get rustc to emit the correct rv32 SRLI instruction. This has been backported to llvm release here: llvm/llvm-project-release-prs@201faec
Note: I made this PR by following these instructions: https://rustc-dev-guide.rust-lang.org/backend/updating-llvm.html#bugfix-updates