Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UI test for issue #35144 #114092

Closed
wants to merge 1 commit into from
Closed

Add UI test for issue #35144 #114092

wants to merge 1 commit into from

Conversation

apiraino
Copy link
Contributor

This should finally close #35144

I am not sure if this test is correct. ideally the test should:

  • run the code with and without the feature flag
  • compare the output of both runs, they should be the same

I'm reading the UI tests documentation to learn if this case is covered.

Opinions?

@rustbot
Copy link
Collaborator

rustbot commented Jul 26, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @b-naber (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 26, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@compiler-errors
Copy link
Member

compiler-errors commented Jul 26, 2023 •
edited
Loading

can we name the test something different than "issue-35144" 😅

@compiler-errors
Copy link
Member

also what is this exercising? it should probably not live in issues/ either.

@apiraino
Copy link
Contributor Author

I'd like to postpone the file naming after compiler-team#658 😄

also what is this exercising? it should probably not live in issues/ either.

Hmm can you clarify? Do you mean the subdir ./issues is only for issues and not for tests ancillary to PRs?

@compiler-errors
Copy link
Member

No, issues/ is a dump for issues that are totally nonspecific. It shouldn't be used, and eventually it will hit the file limit and stop even being usable. The test should go into one of the many many other directories that better describe what it's actually testing.

I'd like to postpone the file naming [...]

I think you can come up with a better name even if we revert programmatically linting against bad issue test names 😄

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 27, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Jul 28, 2023

☔ The latest upstream changes (presumably #114144) made this pull request unmergeable. Please resolve the merge conflicts.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@apiraino apiraino removed the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jul 28, 2023
@compiler-errors
Copy link
Member

(For the record, merge commits are not allowed in PRs -- see https://rustc-dev-guide.rust-lang.org/git.html#no-merge-policy)

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jul 31, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jul 31, 2023

Some changes occurred in src/tools/cargo

cc @ehuss

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@apiraino apiraino force-pushed the add-test-for-issue-35144 branch from 28d0fad to 9c237f2 Compare July 31, 2023 14:45
@apiraino apiraino force-pushed the add-test-for-issue-35144 branch from 9c237f2 to 7112622 Compare July 31, 2023 15:27
@bors
Copy link
Contributor

bors commented Jul 31, 2023

☔ The latest upstream changes (presumably #114294) made this pull request unmergeable. Please resolve the merge conflicts.

@lqd
Copy link
Member

lqd commented Aug 10, 2023

Some changes occurred in src/tools/cargo

it's because you have updated the cargo submodule in this PR, https://github.com/rust-lang/rust/pull/114092/files#diff-33f03135675a053d29237bf61b13441e9f52fff29207605b5eb224c2f6e3507c

@apiraino
Copy link
Contributor Author

I will get back to this Soon (:tm: )

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 24, 2023
@Dylan-DPC
Copy link
Member

@apiraino any updates on this?

@apiraino
Copy link
Contributor Author

apiraino commented Nov 5, 2023

yes, I will be back on this at some point. Please don't take any action, if possible. Converting to draft if it helps clarifying the status.

@apiraino apiraino marked this pull request as draft November 5, 2023 14:46
@Dylan-DPC
Copy link
Member

You don't need to convert to draft, as long as there is intent that you are still working on it which you've done already :P

apiraino
apiraino commented Dec 6, 2023
View reviewed changes
src/tools/tidy/src/ui_tests.rs
Comment on lines +13 to +16
// Max number of files under "./ui/issues"
const ISSUES_ENTRY_LIMIT: usize = 1892;
// Max number of files under "./ui"
const ROOT_ENTRY_LIMIT: usize = 871;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally I shouldnt need to touch this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless maybe you're moving things out of this folder. Otherwise, you are already adding a tests in a subfolder, so things should be fine from that point.

@apiraino
Copy link
Contributor Author

I'll circle back on this at another time

@apiraino apiraino closed this Jan 25, 2024
@apiraino apiraino deleted the add-test-for-issue-35144 branch January 25, 2024 11:50
@apiraino apiraino removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqd lqd lqd left review comments

Assignees

@b-naber b-naber

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

type_id is not crate-independent with object associated types
8 participants
@apiraino @rustbot @rust-log-analyzer @compiler-errors @bors @lqd @Dylan-DPC @b-naber