Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mishandled --check-cfg arguments order #111292

Merged
merged 1 commit into from
May 11, 2023
Merged

Fix mishandled --check-cfg arguments order #111292

merged 1 commit into from
May 11, 2023

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented May 6, 2023 •
edited
Loading

This PR fixes a bug in --check-cfg where the order of --check-cfg=names(a) and --check-cfg=values(a,…) would trip the compiler.

Fixes #111291
cc @taiki-e @petrochenkov

@Urgau Urgau marked this pull request as ready for review May 6, 2023 16:40
@rustbot
Copy link
Collaborator

rustbot commented May 6, 2023

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 6, 2023
@Urgau Urgau force-pushed the check-cfg-issue-111291 branch from 44a7da4 to f4ca42f Compare May 6, 2023 16:40
@petrochenkov
Copy link
Contributor

r? @petrochenkov

@rustbot rustbot assigned petrochenkov and unassigned TaKO8Ki May 9, 2023
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented May 9, 2023

📌 Commit f4ca42f has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2023
@bors
Copy link
Contributor

bors commented May 10, 2023

⌛ Testing commit f4ca42f with merge f3c173daf24e7a7fc5d8573c018d4146ccea2040...

@bors
Copy link
Contributor

bors commented May 10, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 10, 2023
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@petrochenkov
Copy link
Contributor

@bors treeclosed=100 github outage https://www.githubstatus.com/incidents/pr3498h3qkfy

@petrochenkov
Copy link
Contributor

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2023
@bors bors mentioned this pull request May 10, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request May 11, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 11, 2023
@bors
Auto merge of rust-lang#111452 - matthiaskrgr:rollup-uic8dgy, r=matth…
4d941cd 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#108705 (Prevent ICE with broken borrow in closure)
 - rust-lang#111292 (Fix mishandled `--check-cfg` arguments order)
 - rust-lang#111382 (Isolate coverage FFI type layouts from their underlying LLVM C++ types)
 - rust-lang#111385 (vec-shrink-panik: update expectations to work on LLVM 17)
 - rust-lang#111389 (Add esp-idf platform-support page)
 - rust-lang#111432 (Use visit_assign to detect SSA locals.)
 - rust-lang#111448 (Use proper impl self type for alias impl in rustdoc)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit aa9adf4 into rust-lang:master May 11, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 11, 2023
@Urgau Urgau deleted the check-cfg-issue-111291 branch May 11, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.

ICE: 'compiler/rustc_interface/src/interface.rs:181:45: shoudn't be possible'
6 participants
@Urgau @rustbot @petrochenkov @bors @rust-log-analyzer @TaKO8Ki