Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync portable-simd to 2023 May 10 #111429

Closed
wants to merge 91 commits into from
Closed

Sync portable-simd to 2023 May 10 #111429

wants to merge 91 commits into from

Conversation

workingjubilee
Copy link
Member

It's been a little while since this has been updated because I've been unfortunately distracted. Let's fix that.

r? @ghost

thomcc and others added 30 commits July 21, 2022 14:53
@thomcc
rust-lang/portable-simd#289: Strengthen warnings about relying on Mas…
b5f9d43 
…k layout

This makes it more clear that you can't rely on the layout of these,
which seems worth doing given that the names vaguely suggest that you can
(and the docs only clarify that you can't on Mask but not the maskNxM aliases).
@RalfJung
make some Miri backtraces more pretty
ddede9f
@calebzulawski
Fix interleave/deinterleave for vectors with only one lane
3183afb
@calebzulawski
Merge pull request rust-lang#295 from RalfJung/miri-backtraces
691c8b2 
make some Miri backtraces more pretty
@programmerjake
add all_lane_counts feature to enable non-power-of-2 lane counts <= 64
8742a86
@calebzulawski
Simplify interleave/deinterleave and fix for odd-length vectors.
6bf5128
@calebzulawski
Hide rustc unstable feature from docs
c739af3
@calebzulawski
Remove special case for length-1 vectors
d030301
@calebzulawski
Simplify expression
5f70664
@calebzulawski
Merge pull request rust-lang#299 from rust-lang/interleave-one
7145dc5 
Fix interleave/deinterleave for vectors with only one lane
@programmerjake
Merge pull request rust-lang#300 from programmerjake/all_lane_counts
d5cd4a8 
add all_lane_counts feature to enable non-power-of-2 lane counts <= 64
@miguelraz @workingjubilee
add feature flag
2c5ebfb 
couldn't run the `hellosimd` without it 🤷🏾
@calebzulawski
Mark more mask functions inline
4491309
@calebzulawski
Update readme
ee9a23f
@calebzulawski @programmerjake
Update README.md
f236f57 
Co-authored-by: Jacob Lifshay <[email protected]>
@calebzulawski
Merge pull request rust-lang#309 from rust-lang/mask-inline
2f38f70 
Mark more mask functions inline
@calebzulawski
Merge pull request rust-lang#310 from rust-lang/readme
aad8f0a 
Update readme
@calebzulawski
Specify aliases in one place, and make it more uniform which are defined
61a6f18
@calebzulawski
Improve variable names
402b50a
@calebzulawski
Merge pull request rust-lang#311 from rust-lang/alias
7c80b69 
Specify aliases in one place, and make it more uniform which are defined
@calebzulawski
Add vectors of pointers
d3cfd7c
@calebzulawski
Use safe casts
7e96f5d
@calebzulawski
Implement scatter/gather with new pointer vector and add tests
4076ba8
@calebzulawski
Add missing safety comment
6b3c599
@calebzulawski
Fix wrapping pointer arithmetic
f10e591
@calebzulawski
Test a more useful pointer
da25087
@calebzulawski
Fix casts
e7cc021
@calebzulawski
Clarify addr and with_addr implementations
8a5a573
@calebzulawski
Update for new intrinsics
176cc81
@calebzulawski
Remove duplicate intrinsic
dadf98a
@BoxyUwU
Copy link
Member

BoxyUwU commented May 10, 2023

is the title supposed to be 2023 May 10, its not 2022 anymore somehow

@workingjubilee
Copy link
Member Author

Oops.

@workingjubilee workingjubilee changed the title Sync portable-simd to 2022 May 10 Sync portable-simd to 2023 May 10 May 11, 2023
@workingjubilee workingjubilee force-pushed the sync-portable-simd-2022-may-10 branch from e0c7512 to fb42fac Compare May 11, 2023 01:29
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@workingjubilee
Copy link
Member Author

Oh, these are much more exciting failures. I thought I hunted all these down, but guess not.

@workingjubilee
Copy link
Member Author

I wonder if the float_to_int_unchecked trigger is correct, as that should be truncating.

@workingjubilee
Copy link
Member Author

Oh, these are the miri tests, and miri is a subtree now. So I can just fix this. Cool.

@workingjubilee
miri: Move patterns for simd tests
dac348e 
It isn't clear to me why these error patterns do not trigger,
but I am not going to waste time analyzing bugs in compiletest.
@rustbot
Copy link
Collaborator

rustbot commented May 11, 2023

The Miri subtree was changed

cc @rust-lang/miri

@workingjubilee
Copy link
Member Author

I believe that's all of them. @bors r+

@bors
Copy link
Contributor

bors commented May 11, 2023

📌 Commit dac348e has been approved by workingjubilee

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented May 11, 2023

🌲 The tree is currently closed for pull requests below priority 50. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 11, 2023
@workingjubilee
Copy link
Member Author

GitHub claims they have resolved the incident.
@bors treeclosed-

@workingjubilee
Copy link
Member Author

@bors p=1

@bors
Copy link
Contributor

bors commented May 11, 2023

⌛ Testing commit dac348e with merge 367906d9e5a165216b08b0c1e7bc1283b77e2126...

@rust-log-analyzer
Copy link
Collaborator

The job dist-various-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
[RUSTC-TIMING] cc test:false 0.573
[RUSTC-TIMING] build_script_build test:false 0.423
   Compiling core v0.0.0 (/checkout/library/core)
   Compiling compiler_builtins v0.1.91
error[E0432]: unresolved import `core::arch::arm::vtbl1_u8`
  --> library/core/src/../../portable-simd/crates/core_simd/src/swizzle_dyn.rs:22:42
   |
22 |         use core::arch::arm::{uint8x8_t, vtbl1_u8};
   |                                          ^^^^^^^^ no `vtbl1_u8` in `core_arch::arch::arm`
For more information about this error, try `rustc --explain E0432`.
[RUSTC-TIMING] core test:false 6.220
error: could not compile `core` (lib) due to previous error
Build completed unsuccessfully in 0:18:34

@bors
Copy link
Contributor

bors commented May 11, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 11, 2023
@bors
Copy link
Contributor

bors commented May 11, 2023

☔ The latest upstream changes (presumably #111454) made this pull request unmergeable. Please resolve the merge conflicts.

@workingjubilee
Copy link
Member Author

RIP.

@workingjubilee
Copy link
Member Author

Re-opened as #111475 because incoherent reasons

@workingjubilee workingjubilee deleted the sync-portable-simd-2022-may-10 branch July 31, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.