Use `Symbol` for the crate name instead of `String`/`str` #105423

oli-obk · 2022-12-07T14:09:37Z

It always got converted to a symbol anyway

oli-obk · 2022-12-07T14:09:46Z

rustbot · 2022-12-07T14:09:47Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jackh726 (or someone else) soon.

Please see the contribution instructions for more information.

bors · 2022-12-07T14:09:56Z

⌛ Trying commit 1674a9f0303a8114da0c66e5ecef9ff95e073b68 with merge 958e94f18e95114bf90df89e837557d94c2ab03f...

bors · 2022-12-07T16:38:56Z

☀️ Try build successful - checks-actions
Build commit: 958e94f18e95114bf90df89e837557d94c2ab03f (958e94f18e95114bf90df89e837557d94c2ab03f)

jackh726 · 2022-12-07T18:13:53Z

r=me with clean perf

rust-timer · 2022-12-07T20:18:12Z

Finished benchmarking commit (958e94f18e95114bf90df89e837557d94c2ab03f): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	6.5%	[0.4%, 15.3%]	7
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.6%	[2.4%, 10.7%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	6.2%	[2.6%, 13.4%]	7
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

oli-obk · 2022-12-07T20:30:27Z

@bors try @rust-timer queue

bors · 2022-12-07T20:30:35Z

⌛ Trying commit d30848b with merge 33a004ce2e7f2e67c4d74e0ce8f81544e17b2eed...

bors · 2022-12-07T22:38:28Z

☀️ Try build successful - checks-actions
Build commit: 33a004ce2e7f2e67c4d74e0ce8f81544e17b2eed (33a004ce2e7f2e67c4d74e0ce8f81544e17b2eed)

bors · 2022-12-07T22:38:29Z

☀️ Try build successful - checks-actions
Build commit: 33a004ce2e7f2e67c4d74e0ce8f81544e17b2eed (33a004ce2e7f2e67c4d74e0ce8f81544e17b2eed)

rust-timer · 2022-12-07T23:56:58Z

Finished benchmarking commit (33a004ce2e7f2e67c4d74e0ce8f81544e17b2eed): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.8%	[-0.8%, -0.8%]	1
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

oli-obk · 2022-12-08T08:07:10Z

@bors r=jackh726 rollup

bors · 2022-12-08T08:07:12Z

📌 Commit d30848b has been approved by jackh726

It is now in the queue for this repository.

…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#104922 (Detect long types in E0308 and write them to disk) - rust-lang#105120 (kmc-solid: `std::sys` code maintenance) - rust-lang#105255 (Make nested RPIT inherit the parent opaque's generics.) - rust-lang#105317 (make retagging work even with 'unstable' places) - rust-lang#105405 (Stop passing -export-dynamic to wasm-ld.) - rust-lang#105408 (Add help for `#![feature(impl_trait_in_fn_trait_return)]`) - rust-lang#105423 (Use `Symbol` for the crate name instead of `String`/`str`) - rust-lang#105433 (CI: add missing line continuation marker) - rust-lang#105434 (Fix warning when libcore is compiled with no_fp_fmt_parse) - rust-lang#105441 (Remove `UnsafetyState`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

Use `Symbol` for the crate name instead of `String`/`str` It always got converted to a symbol anyway

…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#104922 (Detect long types in E0308 and write them to disk) - rust-lang#105120 (kmc-solid: `std::sys` code maintenance) - rust-lang#105255 (Make nested RPIT inherit the parent opaque's generics.) - rust-lang#105317 (make retagging work even with 'unstable' places) - rust-lang#105405 (Stop passing -export-dynamic to wasm-ld.) - rust-lang#105408 (Add help for `#![feature(impl_trait_in_fn_trait_return)]`) - rust-lang#105423 (Use `Symbol` for the crate name instead of `String`/`str`) - rust-lang#105433 (CI: add missing line continuation marker) - rust-lang#105434 (Fix warning when libcore is compiled with no_fp_fmt_parse) - rust-lang#105441 (Remove `UnsafetyState`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

…rochenkov give the resolver access to TyCtxt The resolver is now created after TyCtxt is created. Then macro expansion and name resolution are run and the results fed into queries just like before this PR. Since the resolver had (before this PR) mutable access to the `CStore` and the source span table, these two datastructures are now behind a `RwLock`. To ensure that these are not mutated anymore after the resolver is done, a read lock to them is leaked right after the resolver finishes. ### PRs split out of this one and leading up to it: * rust-lang#105423 * rust-lang#105357 * rust-lang#105603 * rust-lang#106776 * rust-lang#106810 * rust-lang#106812 * rust-lang#108032

give the resolver access to TyCtxt The resolver is now created after TyCtxt is created. Then macro expansion and name resolution are run and the results fed into queries just like before this PR. Since the resolver had (before this PR) mutable access to the `CStore` and the source span table, these two datastructures are now behind a `RwLock`. To ensure that these are not mutated anymore after the resolver is done, a read lock to them is leaked right after the resolver finishes. ### PRs split out of this one and leading up to it: * rust-lang/rust#105423 * rust-lang/rust#105357 * rust-lang/rust#105603 * rust-lang/rust#106776 * rust-lang/rust#106810 * rust-lang/rust#106812 * rust-lang/rust#108032

rustbot assigned jackh726 Dec 7, 2022

This comment has been minimized.

Sign in to view

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Dec 7, 2022

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Dec 7, 2022

Use Symbol for the crate name instead of String/str

d30848b

oli-obk force-pushed the symbols branch from f50aedc to d30848b Compare December 7, 2022 20:30

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 7, 2022

This comment has been minimized.

Sign in to view

rustbot removed S-waiting-on-perf Status: Waiting on a perf run to be completed. perf-regression Performance regression. labels Dec 7, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 8, 2022

matthiaskrgr mentioned this pull request Dec 8, 2022

Rollup of 10 pull requests #105456

Merged

oli-obk mentioned this pull request Dec 8, 2022

give the resolver access to TyCtxt #105462

Merged

bors merged commit fbfc5ad into rust-lang:master Dec 9, 2022

rustbot added this to the 1.67.0 milestone Dec 9, 2022

Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023

Rollup merge of rust-lang#105423 - oli-obk:symbols, r=jackh726

7248990

Use `Symbol` for the crate name instead of `String`/`str` It always got converted to a symbol anyway

albertlarsan68 mentioned this pull request Jan 9, 2023

Regression in Beta/Nightly: implementation of Trait is not general enough #106630

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use `Symbol` for the crate name instead of `String`/`str` #105423

Use `Symbol` for the crate name instead of `String`/`str` #105423

oli-obk commented Dec 7, 2022

oli-obk commented Dec 7, 2022

rustbot commented Dec 7, 2022

This comment has been minimized.

bors commented Dec 7, 2022

bors commented Dec 7, 2022

This comment has been minimized.

jackh726 commented Dec 7, 2022

rust-timer commented Dec 7, 2022

oli-obk commented Dec 7, 2022

This comment has been minimized.

bors commented Dec 7, 2022

bors commented Dec 7, 2022

bors commented Dec 7, 2022

This comment has been minimized.

rust-timer commented Dec 7, 2022

oli-obk commented Dec 8, 2022

bors commented Dec 8, 2022

Use Symbol for the crate name instead of String/str #105423

Use Symbol for the crate name instead of String/str #105423

Conversation

oli-obk commented Dec 7, 2022

oli-obk commented Dec 7, 2022

rustbot commented Dec 7, 2022

This comment has been minimized.

bors commented Dec 7, 2022

bors commented Dec 7, 2022

This comment has been minimized.

jackh726 commented Dec 7, 2022

rust-timer commented Dec 7, 2022

Overall result: ❌ regressions - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

oli-obk commented Dec 7, 2022

This comment has been minimized.

bors commented Dec 7, 2022

bors commented Dec 7, 2022

bors commented Dec 7, 2022

This comment has been minimized.

rust-timer commented Dec 7, 2022

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

oli-obk commented Dec 8, 2022

bors commented Dec 8, 2022

Use `Symbol` for the crate name instead of `String`/`str` #105423

Use `Symbol` for the crate name instead of `String`/`str` #105423