Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix testing prerequisites #3946

Closed
brson opened this issue Nov 10, 2012 · 0 comments
Closed

Fix testing prerequisites #3946

brson opened this issue Nov 10, 2012 · 0 comments
Assignees
@brson

Comments

@brson
Copy link
Contributor

brson commented Nov 10, 2012

A change I made recently to add the new libraries to the install target made running tests require building all the tool libraries
@ghost ghost assigned brson Nov 10, 2012
@brson brson closed this as completed in cf002e9 Nov 14, 2012
bors pushed a commit to rust-lang-ci/rust that referenced this issue May 15, 2021
@topecongiro
Do not add block around async closure (rust-lang#3946)
731f155
RalfJung pushed a commit to RalfJung/rust that referenced this issue Oct 15, 2024
@bors
Auto merge of rust-lang#3946 - FrankReh:fix-over-synchronization-of-e…
5cdee07 
…poll, r=RalfJung

Fix over synchronization of epoll

Fixes rust-lang#3944.

The clock used by epoll is now per event generated, rather than by the `epoll's` ready_list.

The same epoll tests that existed before are unchanged and still pass. Also the `tokio` test case we had worked on last week still passes with this change.

This change does beg the question of how the epoll event states should change. Perhaps rather than expose public crate bool fields, so setters should be provided that include a clock parameter or an optional clock parameter. Also should all the epoll event possibilities have their clock sync tested the way these commit lay out testing. In this first go around, only the pipe's EPOLLIN is tested. The EPOLLOUT might deserve testing too, as would the eventfd. Any future source of epoll events would also fit into that category.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brson