Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert compiler to use Drop trait #3944

Closed
bstrie opened this issue Nov 9, 2012 · 5 comments
Closed

Convert compiler to use Drop trait #3944

bstrie opened this issue Nov 9, 2012 · 5 comments
Assignees
@pcwalton
Labels
A-trait-system Area: Trait system C-cleanup Category: PRs that clean code up or issues documenting cleanup. metabug Issues about issues themselves ("bugs about bugs")
Milestone
0.7

Comments

@bstrie
Copy link
Contributor

bstrie commented Nov 9, 2012

pcwalton asserts that the Drop trait is implemented, though perhaps buggy. Use this to replace the drop block in structs.
This was referenced Nov 14, 2012
Closed
Closed
@bstrie bstrie mentioned this issue Mar 7, 2013
Closed
@bstrie
Copy link
Contributor Author

bstrie commented Mar 15, 2013

Blocked on #5377, #5378, #5379, #5380, #5382

@catamorphism
Copy link
Contributor

Looks unlikely to get done for 0.6, alas. De-milestoning

@graydon
Copy link
Contributor

graydon commented Apr 30, 2013

@pcwalton is this in-scope or related to what you're doing in 0.7?

@graydon
Copy link
Contributor

graydon commented Apr 30, 2013

assigning bug; change assignment if you disagree

@ghost ghost assigned pcwalton Apr 30, 2013
@bstrie bstrie mentioned this issue May 1, 2013
Closed
@bstrie
Copy link
Contributor Author

bstrie commented May 6, 2013

Drop blocks are gone!

@bstrie bstrie closed this as completed May 6, 2013
RalfJung pushed a commit to RalfJung/rust that referenced this issue Oct 15, 2024
@bors
Auto merge of rust-lang#3946 - FrankReh:fix-over-synchronization-of-e…
5cdee07 
…poll, r=RalfJung

Fix over synchronization of epoll

Fixes rust-lang#3944.

The clock used by epoll is now per event generated, rather than by the `epoll's` ready_list.

The same epoll tests that existed before are unchanged and still pass. Also the `tokio` test case we had worked on last week still passes with this change.

This change does beg the question of how the epoll event states should change. Perhaps rather than expose public crate bool fields, so setters should be provided that include a clock parameter or an optional clock parameter. Also should all the epoll event possibilities have their clock sync tested the way these commit lay out testing. In this first go around, only the pipe's EPOLLIN is tested. The EPOLLOUT might deserve testing too, as would the eventfd. Any future source of epoll events would also fit into that category.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcwalton pcwalton

Labels
A-trait-system Area: Trait system C-cleanup Category: PRs that clean code up or issues documenting cleanup. metabug Issues about issues themselves ("bugs about bugs")
Projects
None yet
Milestone
0.7
Development

No branches or pull requests
4 participants
@graydon @pcwalton @catamorphism @bstrie