Move allow dead code attribute and add comment #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @marioidival (or someone else) soon. Please see the contribution instructions for more information. |
marioidival
approved these changes
Mar 21, 2022
|
@khandrym cool! Thank you for that! |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 29, 2022
Update books ## nomicon 3 commits in f6d6126fc96ecf4a7f7d22da330df9506293b0d0..11f1165e8a2f5840467e748c8108dc53c948ee9a 2022-02-26 02:21:21 +0900 to 2022-03-19 16:02:00 -0400 - Make the Vec impl be slightly more careful with ZSTs and alignment. - implement `IntoIterator` for `Vec` (rust-lang/nomicon#337) - Add an explanation shared to exclusive transmute (rust-lang/nomicon#344) ## reference 2 commits in 0a2fe6651fbccc6416c5110fdf5b93fb3cb29247..c97d14fa6fed0baa9255432b8a93cb70614f80e3 2022-03-15 09:32:25 -0700 to 2022-03-19 18:18:10 -0700 - Fixed inconsistency in the usage of semicolon at end of scopes (rust-lang/reference#1182) - Document ADX `target_feature` (rust-lang/reference#1172) ## book 23 commits in 036e88a4f135365de85358febe5324976a56030a..ea90bbaf53ba64ef4e2da9ac2352b298aec6bec8 2022-03-04 21:53:33 -0500 to 2022-03-28 21:59:34 -0400 - Fix nostarch snapshot - Snapshot of chapter 7 for nostarch - Add a forward reference to chapter 14, another example of pub use - Clarify pub use example. Fixes rust-lang/book#2716. - Fancy quotes - Fix incorrectly worded sentence. Fixes rust-lang/book#3086. - Reword description of how a listing came to be - Call out binary+library crate practices - Define binary and library crates more explicitly - Clarify when a path is a crate name and when it should be literal crate - Make it clearer the outer `mod` doesn't move to the file - Don't wrap this example in main when copying. Fixes rust-lang/book#2930. - Try to make clearer that `mod` is not an `import` - Mention mod.rs file naming scheme - Explain why submodule subdirectories are needed more - Rename a separate example of serve_order to deliver_order - Show an example that `use` only applies in its own scope - quick modules guide - Tweak a snippet of ch18-03 - Propagating edits to chapter 10 back - Responses to nostarch questions of chapter 10 - Update src/ch04-01-what-is-ownership.md - Add Danish translation link. Connects to rust-lang/book#3079. ## rust-by-example 2 commits in d504324f1e7dc7edb918ac39baae69f1f1513b8e..ec954f35eedf592cd173b21c05a7f80a65b61d8a 2022-03-07 09:26:32 -0300 to 2022-03-22 11:09:06 -0300 - PathBuf details and example (rust-lang/rust-by-example#1519) - Move allow dead code attribute and add comment (rust-lang/rust-by-example#1518) ## rustc-dev-guide 1 commits in 0e4b961..155126b 2022-03-14 08:40:37 -0700 to 2022-03-22 14:34:21 +0100 - update section for type system constants (rust-lang/rustc-dev-guide#1329) ## embedded-book 1 commits in d5fc1bce3f8eb398f9c25f1b15e0257d7537cd41..a6de8b6e3ea5d4f0de8b7b9a7e5c1405dc2c2ddb 2022-01-24 07:13:31 +0000 to 2022-03-17 21:21:39 +0000 - Update OpenOCD install instruction for rust-embedded/book#313 (rust-embedded/book#314)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @marioidival,
The attribute #![allow(dead_code)] is first time mentioned in section [3.1. Structures]. So my proposition for this section is to move #![allow(dead_code)] attribute to the top of the code and add a comment for it similarly like it is done in other sections (for example in [3.2.1. use] and [3.2.2. C-like]). I think this will help better to understand for the first time what this attribute is for.