Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain pub use in Chapter 7 with a more robust example #2716

Closed
Defman21 opened this issue May 5, 2021 · 1 comment · Fixed by rust-lang/rust#95423
Closed

Explain pub use in Chapter 7 with a more robust example #2716

Defman21 opened this issue May 5, 2021 · 1 comment · Fixed by rust-lang/rust#95423
Labels
Q for ourselves
Milestone
ch7

Comments

@Defman21
Copy link

Defman21 commented May 5, 2021 •
edited
Loading

In the version 1.0.0 of the book, the example for the pub use keyword is more self-explanatory than in the current one because it demonstrates how exactly pub use works (instead of calling languages::japanese::greetings::hello we can simply do languages::japanese::hello if we include pub use self::greetings in the languages::japanese module). The current version only slightly mentions its behavior:

By using pub use, external code can now call the add_to_waitlist function using hosting::add_to_waitlist. If we hadn’t specified pub use, the eat_at_restaurant function could call hosting::add_to_waitlist in its scope, but external code couldn’t take advantage of this new path.

An example showing how it would be called in an external module similar to the version 1.0.0 would be much helpful to understand the concept of re-export.
@carols10cents carols10cents added this to the ch7 milestone Jul 14, 2021
@limuyuan
Copy link
Contributor

limuyuan commented Aug 2, 2021

Strongly agree. I also find myself unable to understand what would happen if pub use is not used.

@carols10cents carols10cents mentioned this issue Mar 27, 2022
Closed
carols10cents added a commit that referenced this issue Mar 29, 2022
@carols10cents
Clarify pub use example. Fixes #2716.
ab059f4
carols10cents added a commit that referenced this issue Mar 29, 2022
@carols10cents
Clarify pub use example. Fixes #2716.
9285d36
@ehuss ehuss mentioned this issue Mar 29, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Mar 29, 2022
@bors
Auto merge of rust-lang#95423 - ehuss:update-books, r=ehuss
14328e6 
Update books

## nomicon

3 commits in f6d6126fc96ecf4a7f7d22da330df9506293b0d0..11f1165e8a2f5840467e748c8108dc53c948ee9a
2022-02-26 02:21:21 +0900 to 2022-03-19 16:02:00 -0400
- Make the Vec impl be slightly more careful with ZSTs and alignment.
- implement `IntoIterator` for `Vec` (rust-lang/nomicon#337)
- Add an explanation shared to exclusive transmute (rust-lang/nomicon#344)

## reference

2 commits in 0a2fe6651fbccc6416c5110fdf5b93fb3cb29247..c97d14fa6fed0baa9255432b8a93cb70614f80e3
2022-03-15 09:32:25 -0700 to 2022-03-19 18:18:10 -0700
- Fixed inconsistency in the usage of semicolon at end of scopes (rust-lang/reference#1182)
- Document ADX `target_feature` (rust-lang/reference#1172)

## book

23 commits in 036e88a4f135365de85358febe5324976a56030a..ea90bbaf53ba64ef4e2da9ac2352b298aec6bec8
2022-03-04 21:53:33 -0500 to 2022-03-28 21:59:34 -0400
- Fix nostarch snapshot
- Snapshot of chapter 7 for nostarch
- Add a forward reference to chapter 14, another example of pub use
- Clarify pub use example. Fixes rust-lang/book#2716.
- Fancy quotes
- Fix incorrectly worded sentence. Fixes rust-lang/book#3086.
- Reword description of how a listing came to be
- Call out binary+library crate practices
- Define binary and library crates more explicitly
- Clarify when a path is a crate name and when it should be literal crate
- Make it clearer the outer `mod` doesn't move to the file
- Don't wrap this example in main when copying. Fixes rust-lang/book#2930.
- Try to make clearer that `mod` is not an `import`
- Mention mod.rs file naming scheme
- Explain why submodule subdirectories are needed more
- Rename a separate example of serve_order to deliver_order
- Show an example that `use` only applies in its own scope
- quick modules guide
- Tweak a snippet of ch18-03
- Propagating edits to chapter 10 back
- Responses to nostarch questions of chapter 10
- Update src/ch04-01-what-is-ownership.md
- Add Danish translation link. Connects to rust-lang/book#3079.

## rust-by-example

2 commits in d504324f1e7dc7edb918ac39baae69f1f1513b8e..ec954f35eedf592cd173b21c05a7f80a65b61d8a
2022-03-07 09:26:32 -0300 to 2022-03-22 11:09:06 -0300
- PathBuf details and example (rust-lang/rust-by-example#1519)
- Move allow dead code attribute and add comment (rust-lang/rust-by-example#1518)

## rustc-dev-guide

1 commits in 0e4b961..155126b
2022-03-14 08:40:37 -0700 to 2022-03-22 14:34:21 +0100
- update section for type system constants (rust-lang/rustc-dev-guide#1329)

## embedded-book

1 commits in d5fc1bce3f8eb398f9c25f1b15e0257d7537cd41..a6de8b6e3ea5d4f0de8b7b9a7e5c1405dc2c2ddb
2022-01-24 07:13:31 +0000 to 2022-03-17 21:21:39 +0000
- Update OpenOCD install instruction for rust-embedded/book#313  (rust-embedded/book#314)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Q for ourselves
Projects
None yet
Milestone
ch7
Development

Successfully merging a pull request may close this issue.

Update books ehuss/rust
3 participants
@carols10cents @Defman21 @limuyuan