Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert breaking musl change #1484

Merged
merged 3 commits into from
Aug 20, 2019
Merged

Revert breaking musl change #1484

merged 3 commits into from
Aug 20, 2019

Conversation

gnzlbg
Copy link
Contributor

@gnzlbg gnzlbg commented Aug 20, 2019

No description provided.

@rust-highfive
Copy link

@gnzlbg: no appropriate reviewer found, use r? to override

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Aug 20, 2019

@bors: r+
@bors p=100

@bors
Copy link
Contributor

bors commented Aug 20, 2019

📌 Commit 1dd09fb has been approved by gnzlbg

bors added a commit that referenced this pull request Aug 20, 2019
Revert breaking musl change
@bors
Copy link
Contributor

bors commented Aug 20, 2019

⌛ Testing commit 1dd09fb with merge fa63103...

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Aug 20, 2019

cc @xen0n - this reverts some of the changes in your PR due to #1483

@xen0n
Copy link
Contributor

xen0n commented Aug 20, 2019

Ahh, that's unfortunate... Awkward moment.

I'll be investigating this in a few days, currently busy IRL. Sorry for the breakage!

@bors
Copy link
Contributor

bors commented Aug 20, 2019

💔 Test failed - status-azure

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Aug 20, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Aug 20, 2019

📌 Commit 8f50a26 has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Aug 20, 2019

⌛ Testing commit 8f50a26 with merge fd963f4...

bors added a commit that referenced this pull request Aug 20, 2019
Revert breaking musl change
@bors
Copy link
Contributor

bors commented Aug 20, 2019

☀️ Test successful - checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure
Approved by: gnzlbg
Pushing fd963f4 to master...

@bors bors merged commit 8f50a26 into rust-lang:master Aug 20, 2019
@atouchet
Copy link
Contributor

Was 0.2.64 supposed to be published? crates.io still lists 0.2.62 as the latest version.

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Aug 26, 2019 via email

@Osspial
Copy link

Osspial commented Oct 3, 2019

When is this going to get published?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants