Add common profile validation. #10411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
ehuss
force-pushed
the
fix-rustflags-gate
branch
from
c4cd531 to
99bfbbc
Compare
|
@bors: r+ |
|
📌 Commit 99bfbbc has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
ehuss
pushed a commit
to ehuss/cargo
that referenced
this pull request
Feb 22, 2022
Add common profile validation. This fixes an oversight where `rustflags` is not nightly-gated in a profile override (like `[profile.dev.package.foo]`). The problem is that the validation was only being done for the top-level profile. The solution here is to consolidate common profile validation that should be done for both the top level and the overrides. In the process I also fixed validation of `codegen-backend` which also is shared. This will hopefully help prevent other oversights in the future.
This was referenced Feb 22, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 23, 2022
Update cargo 8 commits in ea2a21c994ca1e4d4c49412827b3cf4dcb158b1d..d6cdde584a1f15ea086bae922e20fd27f7165431 2022-02-15 04:24:07 +0000 to 2022-02-22 19:55:51 +0000 - Add common profile validation. (rust-lang/cargo#10411) - Add -Z check-cfg-features to enable compile-time checking of features (rust-lang/cargo#10408) - Remove invalid target-specific dependency example. (rust-lang/cargo#10401) - Fix errors in `cargo fetch` usage guide (rust-lang/cargo#10398) - Fix some broken doc links. (rust-lang/cargo#10404) - Implement "artifact dependencies" (RFC-3028) (rust-lang/cargo#9992) - Print executable name on cargo test --no-run rust-lang/cargo#2 (rust-lang/cargo#10346) - Avoid new deprecation warnings from clap 3.1.0 (rust-lang/cargo#10396)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an oversight where
rustflagsis not nightly-gated in a profile override (like[profile.dev.package.foo]).The problem is that the validation was only being done for the top-level profile.
The solution here is to consolidate common profile validation that should be done for both the top level and the overrides. In the process I also fixed validation of
codegen-backendwhich also is shared. This will hopefully help prevent other oversights in the future.