-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print executable name on cargo test --no-run #2 #10346
Print executable name on cargo test --no-run #2 #10346
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. Please see the contribution instructions for more information. |
r? @ehuss |
7e99086
to
ed579b6
Compare
This is marked as a draft, is there some additional work you want to do? |
@ehuss Yes, you mentioned that you wanted benches to be displayed differently in the other PR. I want to get to that shortly. |
script_meta: &Option<Metadata>, | ||
test_args: &[&str], | ||
compilation: &Compilation<'_>, | ||
exec_type: &str, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ehuss Let me know if you want this to be an enum.
Thanks, looks great! FCP finished in #9959 (comment). @bors r+ |
📌 Commit 0b74ea2 has been approved by |
☀️ Test successful - checks-actions |
Update cargo 8 commits in ea2a21c994ca1e4d4c49412827b3cf4dcb158b1d..d6cdde584a1f15ea086bae922e20fd27f7165431 2022-02-15 04:24:07 +0000 to 2022-02-22 19:55:51 +0000 - Add common profile validation. (rust-lang/cargo#10411) - Add -Z check-cfg-features to enable compile-time checking of features (rust-lang/cargo#10408) - Remove invalid target-specific dependency example. (rust-lang/cargo#10401) - Fix errors in `cargo fetch` usage guide (rust-lang/cargo#10398) - Fix some broken doc links. (rust-lang/cargo#10404) - Implement "artifact dependencies" (RFC-3028) (rust-lang/cargo#9992) - Print executable name on cargo test --no-run rust-lang/cargo#2 (rust-lang/cargo#10346) - Avoid new deprecation warnings from clap 3.1.0 (rust-lang/cargo#10396)
Closes #9957
This is a continuation of #9959.