Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specs for pathname.glob #807

Merged
merged 5 commits into from
Oct 26, 2020
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions library/pathname/glob_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
require_relative '../../spec_helper'
require 'pathname'

describe 'Pathname#glob' do
before :all do
@dir = tmp ''
eregon marked this conversation as resolved.
Show resolved Hide resolved
@file_1 = @dir + 'lib/ipaddr.rb'
@file_2 = @dir + 'lib/irb.rb'
@file_3 = @dir + 'lib/.hidden.rb'

touch @file_1
touch @file_2
touch @file_3
end

after :all do
rm_r @dir
end

it 'returns [] for no match' do
Pathname.glob(@dir + 'lib/*.js').should == []
end

it 'returns matching file paths' do
Pathname.glob(@dir + 'lib/*i*.rb').sort.should == [Pathname.new(@file_1), Pathname.new(@file_2)].sort
end

it 'returns matching file paths when a flag is provided' do
expected = [Pathname.new(@file_1), Pathname.new(@file_2), Pathname.new(@file_3)].sort
Pathname.glob(@dir + 'lib/*i*.rb', File::FNM_DOTMATCH).sort.should == expected
end

it 'returns matching file paths when supplied :base keyword argument' do
Pathname.glob('*i*.rb', base: @dir + 'lib').sort.should == [Pathname.new('ipaddr.rb'), Pathname.new('irb.rb')].sort
end

ruby_version_is ''...'2.7' do
it 'raises an ArgumentError when supplied a flag and :base keyword argument' do
-> {
Pathname.glob(@dir + 'lib/*i*.rb', File::FNM_DOTMATCH, base: 'lib')
}.should raise_error(ArgumentError, 'wrong number of arguments (given 3, expected 1..2)')
end

it "raises an ArgumentError when supplied a keyword argument other than :base" do
-> {
Pathname.glob('*i*.rb', foo: @dir + 'lib')
}.should raise_error(ArgumentError, 'unknown keyword: foo')
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This spec seems to work on all versions, so I think it can moved out of the ruby_version_is guard.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the message was different in the two versions I used
ruby 2.6.3p62 (2019-04-16 revision 67580) [x86_64-darwin18] said foo
while
ruby 2.7.1p83 (2020-03-31 revision a0c7c23c9c) [x86_64-darwin19] said :foo.

I could leave it as two specs or remove the string matching. What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, then you can use a Regexp for the second argument of raise_error:

/unknown keyword: :?foo/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that makes sense. done!

end

ruby_version_is "2.7"..."3.0" do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ruby_version_is "2.7" which means >= 2.7

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

it "does not raise an ArgumentError when supplied a flag and :base keyword argument" do
expected = [Pathname.new('ipaddr.rb'), Pathname.new('irb.rb'), Pathname.new('.hidden.rb')].sort
Pathname.glob('*i*.rb', File::FNM_DOTMATCH, base: @dir + 'lib').sort.should == expected
end

it "raises an ArgumentError when supplied a keyword argument other than :base" do
-> {
Pathname.glob('*i*.rb', foo: @dir + 'lib')
}.should raise_error(ArgumentError, 'unknown keyword: :foo')
end
end
end