Add specs for pathname.glob #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eregon
reviewed
Oct 24, 2020
library/pathname/glob_spec.rb
Outdated
| -> { | ||
| Pathname.glob('*i*.rb', foo: @dir + 'lib') | ||
| }.should raise_error(ArgumentError, 'unknown keyword: foo') | ||
| end |
There was a problem hiding this comment.
This spec seems to work on all versions, so I think it can moved out of the ruby_version_is guard.
There was a problem hiding this comment.
So the message was different in the two versions I used
ruby 2.6.3p62 (2019-04-16 revision 67580) [x86_64-darwin18] said foo
while
ruby 2.7.1p83 (2020-03-31 revision a0c7c23c9c) [x86_64-darwin19] said :foo.
I could leave it as two specs or remove the string matching. What do you think?
There was a problem hiding this comment.
I see, then you can use a Regexp for the second argument of raise_error:
/unknown keyword: :?foo/There was a problem hiding this comment.
that makes sense. done!
library/pathname/glob_spec.rb
Outdated
| end | ||
| end | ||
|
|
||
| ruby_version_is "2.7"..."3.0" do |
There was a problem hiding this comment.
Should be ruby_version_is "2.7" which means >= 2.7
eregon
reviewed
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #745