Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always display message about how to view diff #307

Merged
merged 5 commits into from
Feb 14, 2020
Merged

Always display message about how to view diff #307

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1f54d0c
Always display message about how to view diff
Feb 10, 2020
a9b227d
Show message when diffs are rejected or not opened
Feb 10, 2020
c8e550e
Only set quiet to TRUE when results are accepted
Feb 10, 2020
d89a3d9
Fix whitespaces
Feb 10, 2020
86e575c
Add news item
Feb 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/snapshot.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,12 +247,12 @@ snapshotCompareSingle <- function(
if (interactive) {
response <- readline("Would you like to view the differences between expected and current results [y/n]? ")
if (tolower(response) == "y") {
quiet <- TRUE
result <- viewTestDiff(appDir, testname, interactive, suffix = suffix)[[1]]

if (result == "accept") {
snapshot_pass <- TRUE
snapshot_status <- "updated"
quiet <- TRUE
}
}
}
Expand Down