Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always display message about how to view diff #307

Merged
merged 5 commits into from
Feb 14, 2020
Merged

Always display message about how to view diff #307

merged 5 commits into from
Feb 14, 2020

Conversation

wfjvdham
Copy link
Contributor

Closes #131

@wfjvdham wfjvdham requested a review from wch February 10, 2020 20:14
@wch
Copy link
Collaborator

wch commented Feb 10, 2020

If I'm understanding the logic correctly, it will always show the message about viewing the test diff, even if the changes are accepted and the current results are deleted. If the user tries to view the diff in that case, it won't work.

@wfjvdham
Copy link
Contributor Author

Good point. quiet <- TRUE is now only set when the results are accepted. In the case of rejection (or not viewed) the message will show.

wch
wch approved these changes Feb 13, 2020
View reviewed changes
Copy link
Collaborator

@wch wch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you add an item to NEWS.md?

@wfjvdham
Copy link
Contributor Author

Done!

@wch wch merged commit 0170c66 into rstudio:master Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wch wch wch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show message about how to view diff even if I already saw it
2 participants
@wfjvdham @wch