Remove deprecated functions benchmark tests #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Company <[email protected]>
sloretz
approved these changes
Nov 19, 2024
|
Since the benchmark job (which is the only test that could be affected by the changes on this PR) is only run on a nightly basis, the Rpr job has been successful, and we have one approval, I will go ahead and merge this. I will keep an eye to the nightlies, and revert if there is any issue. |
Crola1702
pushed a commit
that referenced
this pull request
Nov 22, 2024
Signed-off-by: Miguel Company <[email protected]>
MiguelCompany
added a commit
that referenced
this pull request
Nov 25, 2024
Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Miguel Company <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #119 by removing the failing benchmark tests.
Since we deprecated the benchmarked functions in #113, I think it makes sense to remove these tests, and suggested so in #119 (comment)