-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROS2 port perception_pcl #229
Conversation
@klintan is this draft required with your other PR? |
No it is not related. This is including pcl_ros package as well, however without type masquerading it's quite challenging, so it's on hold from my side as of now. |
@mabelzhang you mentioned someone on your end was thinking about or in the middle of porting pcl_ros. Can you connect them with me so we can chat on the best path for this? |
@sloretz is working on porting pcl_ros. I believe there's some blending with the branch in this PR, the last I heard. |
@sloretz you can find my email on my GitHub page (don't want to explicitly list it for the spam bots), we should chat on what you've done, doing, and in your queue so I can complement it and not have dual-work. I'd love to have a componentized-pcl_ros done before end of 2019 |
Whoops, I missed this. I opened #255 for visibility. I'm working on the filters at the moment. |
Most of work comes from PR ros-perception#255/ros-perception#229 by sloretz/klintan
@klintan Is this PR still supposed to be merged? If not I suggest to close (as the title could falsely give impressions that ros2 port is not done even the basic part of it). Looking at #255 (comment) and #225 (and maybe some others), basics seem to be completed. |
Agree, I'll close this one. |
WIP
Wanted to keep it transparent so will start a draft PR. Doing the velodyne package which depends on this one.
Still not compiling, and will probably be working with a bit smaller feature-set before it's fully featured and working.