Skip to content
This repository has been archived by the owner on Dec 4, 2019. It is now read-only.

Repo obsolete or move into perception_pcl branch -- Archive (or delete as to not confuse)? #5

Closed
SteveMacenski opened this issue Jul 31, 2019 · 13 comments
Labels
enhancement New feature or request

Comments

@SteveMacenski
Copy link

No description provided.

@clalancette
Copy link

So, as it stands, we still release this repository into Dashing for the perception_pcl package: https://github.com/ros/rosdistro/blob/master/dashing/distribution.yaml#L880 . I guess upstream does have a crystal-devel branch, but I have no idea of the state or what has been ported there. I'm happy to deprecate this repo once we figure out what is going on there. @SteveMacenski can you take a look and make sure all of the changes here are present upstream? Thanks.

@SteveMacenski
Copy link
Author

SteveMacenski commented Aug 1, 2019

Good to know, I'll add this to my queue to figure out the state of both of these, what's missing, and port over. Might be a few weeks before I get to it.

(this is part of my waging war against duplicate repositories)

@mabelzhang
Copy link

mabelzhang commented Sep 26, 2019

I resolved the diff between the ros2 branch of this repo and this perception_pcl PR port to Dashing ros-perception/perception_pcl#244

If someone from here could give it a review and check that everything from here is there, that would be great.

@SteveMacenski
Copy link
Author

Thanks for poking, I just did

@wjwwood
Copy link
Member

wjwwood commented Oct 24, 2019

@mabelzhang can this be closed?

@wjwwood wjwwood added the enhancement New feature or request label Oct 24, 2019
@mabelzhang
Copy link

@SteveMacenski might have a better idea.
The combining of pcl_conversions here with perception_pcl is still an active PR.
We are also actively working on porting pcl_ros and the plan is still to close this repo and release perception_pcl hopefully in Eloquent.

@clalancette
Copy link

clalancette commented Oct 24, 2019

To close this out we need:

@SteveMacenski
Copy link
Author

SteveMacenski commented Oct 24, 2019

I agree with @clalancette ‘s list

Though the maybe isnt required for feature parity to execute on the rest of this. That’s to actually finish all the pcl porting.

Once we can get 244 in, I’ll immediately turn around and release to dashing/eloquent & remove this repo’s entry from the yaml files. @clalancette do you prefer to do the final commit stuff here?

@SteveMacenski
Copy link
Author

@clalancette @mabelzhang ros/rosdistro#23166 will move ownership in Dashing (later eloquent after merged) to pcl perception. This repo is ready for deprecation/archive.

@SteveMacenski
Copy link
Author

ros/rosdistro#23166
ros/rosdistro#23194

Dashing and Eloquent have been changed to perception_pcl and removed ros2/pcl_conversions

I think this is good now for @clalancette to decommission this repo and archive it.

@clalancette
Copy link

Sorry, I've been slammed the last couple of weeks. I'll try to get to it this week.

@SteveMacenski
Copy link
Author

No worries, just a heads up

@clalancette
Copy link

All right, I've decommissioned this repository. I'm going to close this issue out before archiving it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants