-
Notifications
You must be signed in to change notification settings - Fork 5
Repo obsolete or move into perception_pcl branch -- Archive (or delete as to not confuse)? #5
Comments
So, as it stands, we still release this repository into Dashing for the perception_pcl package: https://github.com/ros/rosdistro/blob/master/dashing/distribution.yaml#L880 . I guess upstream does have a crystal-devel branch, but I have no idea of the state or what has been ported there. I'm happy to deprecate this repo once we figure out what is going on there. @SteveMacenski can you take a look and make sure all of the changes here are present upstream? Thanks. |
Good to know, I'll add this to my queue to figure out the state of both of these, what's missing, and port over. Might be a few weeks before I get to it. (this is part of my waging war against duplicate repositories) |
I resolved the diff between the ros2 branch of this repo and this perception_pcl PR port to Dashing ros-perception/perception_pcl#244 If someone from here could give it a review and check that everything from here is there, that would be great. |
Thanks for poking, I just did |
@mabelzhang can this be closed? |
@SteveMacenski might have a better idea. |
To close this out we need:
|
I agree with @clalancette ‘s list Though the maybe isnt required for feature parity to execute on the rest of this. That’s to actually finish all the pcl porting. Once we can get 244 in, I’ll immediately turn around and release to dashing/eloquent & remove this repo’s entry from the yaml files. @clalancette do you prefer to do the final commit stuff here? |
@clalancette @mabelzhang ros/rosdistro#23166 will move ownership in Dashing (later eloquent after merged) to pcl perception. This repo is ready for deprecation/archive. |
ros/rosdistro#23166 Dashing and Eloquent have been changed to I think this is good now for @clalancette to decommission this repo and archive it. |
Sorry, I've been slammed the last couple of weeks. I'll try to get to it this week. |
No worries, just a heads up |
All right, I've decommissioned this repository. I'm going to close this issue out before archiving it. |
No description provided.
The text was updated successfully, but these errors were encountered: