Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support passing license as file #124

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

arkbriar
Copy link
Collaborator

@arkbriar arkbriar commented Oct 10, 2024

Explanation in Detail

Note

Same as what we did in risingwavelabs/risingwave-operator#732, the environment variable used to pass the file path is RW_LICENSE_KEY_PATH due to a mistake in the original PR.

Example values (tested locally)

metaStore:
  sqlite:
    enabled: true
    
stateStore:
  localFs:
    enabled: true

standalone:
  enabled: true

license:
  secret:
    name: license
    key: license.jwt
  passAsFile: true

image:
  registry: ghcr.io
  repository: risingwavelabs/risingwave
  tag: nightly-20241009

Expectations

  • select rw_test_paid_tier() returns t instead of an error message when a valid license is specified.

Future works

  • When the v2.1 is released, passAsFile will be marked as deprecated in the next helm chart release.
  • When the v2.2 is released, passAsFile will be removed as well as all the related branches.

@arkbriar arkbriar enabled auto-merge October 10, 2024 10:37
@arkbriar arkbriar added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit 2f3c9f5 Oct 11, 2024
1 check passed
@arkbriar arkbriar deleted the shunjie/license-key-as-a-file branch October 11, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants