-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support passing license as file #732
Conversation
Signed-off-by: arkbriar <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #732 +/- ##
==========================================
+ Coverage 55.03% 55.43% +0.40%
==========================================
Files 40 40
Lines 6679 6757 +78
==========================================
+ Hits 3676 3746 +70
- Misses 2877 2884 +7
- Partials 126 127 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
||
// SecretKey to the license in the Secret above. Defaults to `licenseKey`. | ||
// +kubebuilder:default=licenseKey | ||
SecretKey string `json:"secretKey,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmmm, I think it's not necessary to make this configurable. But anyway not a big deal.
What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Note
The environment variable used to pass the file path is
RW_LICENSE_KEY_PATH
due to a mistake in the original PR. We'll keep using it instead of changing it.Checklist
Refer to a related PR or issue link (optional)