Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support passing license as file #732

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

arkbriar
Copy link
Collaborator

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

Note

The environment variable used to pass the file path is RW_LICENSE_KEY_PATH due to a mistake in the original PR. We'll keep using it instead of changing it.

  • Support passing license keys via mounted secret file, which enables automatic license updating. Upstream PR: feat(meta): watch and reload license key from file risingwave#18768
  • Support version based auto detection and enablement of the feature and the ability of manual overriding.
  • The PR maintains backward compatibility at the API level.

Checklist

  • I have written the necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 9 lines in your changes missing coverage. Please review.

Project coverage is 55.43%. Comparing base (c76f925) to head (0d8c9c2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
apis/risingwave/v1alpha1/zz_generated.deepcopy.go 0.00% 6 Missing ⚠️
pkg/factory/risingwave_object_factory.go 96.77% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #732      +/-   ##
==========================================
+ Coverage   55.03%   55.43%   +0.40%     
==========================================
  Files          40       40              
  Lines        6679     6757      +78     
==========================================
+ Hits         3676     3746      +70     
- Misses       2877     2884       +7     
- Partials      126      127       +1     
Flag Coverage Δ
unittests 55.43% <90.90%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


// SecretKey to the license in the Secret above. Defaults to `licenseKey`.
// +kubebuilder:default=licenseKey
SecretKey string `json:"secretKey,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmmm, I think it's not necessary to make this configurable. But anyway not a big deal.

@arkbriar arkbriar added this pull request to the merge queue Oct 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 10, 2024
@arkbriar arkbriar added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit 4cda32b Oct 10, 2024
12 checks passed
@arkbriar arkbriar deleted the shunjie/new-way-to-license branch October 10, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants