msvs: add ARM64 build file generation #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refack
reviewed
Feb 8, 2019
GYP already understands ARM64 from the other platforms it supports, but it did not properly generate ARM ASM rules for Visual Studio. This change adds support for it, from including the right props sheet to emitting MARMASM tags instead of MASM tags. The tags required plumbing the target architecture through a few layers of abstractions so the right file types could be associated with it.
|
Actually we should add a test for this... |
|
I was thinking about that exact question yesterday. There are two big changes: VCXPROJ files can have ARM64 as the Platform and in the Configuration, and .S and .asm files should land in MARMASM tags. |
|
There is a .S+.asm change in node/gyp that is important (nodejs/node@9920dbc). Also, note that I submitted this change as nodejs/node#26020 so it can make it into Node faster, as advised by a contributor. |
This was referenced Feb 25, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of ARM64 Windows desktop (Windows 10 on ARM), GYP's MSVS generator needs to understand how to emit matching VS project files. This change does that.