Support ARM64 Windows desktop #25998

jkunkee · 2019-02-07T23:46:01Z

Is your suggestion related to a problem?
At present the Electron project does not support the new Windows 10 on ARM (ARM64 Win32) platform. One of its dependencies is Node.js, which also does not support it. This means that on these devices Electron apps run emulated which, with the complexity of Electron, means a suboptimal user experience.

Describe the solution you'd like
I would like Node.js to support Windows 10 on ARM. Ideally this would include any tweaks needed to make Electron embedding easier, and I would be pleased as punch to see Node.js host ARM64 Windows EXEs on its main page.

Describe alternatives you've considered
As mentioned earlier, Windows 10 on ARM includes an IA32 emulation layer that runs Node.js. This works well for many applications, but my prototype ARM64 build of Node.js runs much faster in significantly less memory.

jkunkee · 2019-02-08T00:19:33Z

Per my message to the mailing list, this is not a simple request, but it is one for which I'm willing to do most of the heavy lifting.

This was also discussed in the build repo: nodejs/build#1138

My prototyping branch is here:
https://github.com/jkunkee/node/tree/arm64

Branch with everything merged so it builds and passes tests:
https://github.com/jkunkee/node/tree/wip/arm64-merged-for-build

Node.js changes:

OpenSSL configs (PR: openssl: add arm64 Windows config files #26001)
Build system changes (PR: win, build: arm64 port script and doc changes #25995)
Ingest GYP with MARMASM support (PR gyp, win: teach MSVS generator about MARMASM Items #26020 will be overwritten by tools: replace GYP with GYP3 #26620)
Ingest NPM with node-gyp with ARM64 support (PR deps: cherry-pick ARM64 Windows changes to node-gyp #28604)
Node.js v12 picks up deps: cherry-pick ARM64 Windows changes to node-gyp #28604 and deps, v8: strip out overly broad DLL Export annotations #28602

Bonus changes:

Add convenience features to vcbuild.bat (PR: win, build: add arbitrary MSBuild flag option and binlog option #25994)
Add ARM64 Windows to the native modules setup scripts suggested by node-gyp (PR: Add ARM64 Windows tool option felixrieseberg/windows-build-tools#176)

Needed deps updates:

refack · 2019-02-08T00:22:20Z

GYP (necessary change not yet upstream)

What's needed from GYP?
Happy to accept PRs to https://github.com/refack/GYP

jkunkee · 2019-02-08T00:38:45Z

OpenSSL config PR: #26001

jkunkee · 2019-02-08T00:47:13Z

@refack, here you go: refack/GYP3#23

jkunkee · 2019-02-09T23:34:11Z

refack/GYP3#23 also submitted as #26020 so it can be merged sooner.

jefgen · 2019-02-11T05:03:51Z

FYI, @jkunkee the ARM64 change for ICU is here: unicode-org/icu#412, and the ICU issue/ticket is: ICU-20382.

jkunkee · 2019-02-11T19:25:35Z

(progress-tracking comment updated)

jkunkee · 2019-02-11T23:54:14Z

For those interested, my hope is for Electron 6 to support Windows 10 on ARM (natively, not via emulation). electron/electron#16876

jkunkee · 2019-02-19T23:55:56Z

[EDIT: merged info into earlier comment]

This adds ARM64 Windows support in the OpenSSL build system. Since OpenSSL's ARM64 Windows support does not have support for ASM-- that is, VC-WIN64-ARM inherits from VC-noCE-common which has no ASM files--`openssl_no_asm.gypi` is always used for building. This essentially forces the 'no-asm' Configure flag. PR-URL: #26001 Fixes: #25998 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Signed-off-by: Beth Griggs <[email protected]>

This change adds the generated files required for building OpenSSL for Node.js for ARM64 Windows. I did this on a VM running Ubuntu 18.04. The basic workflow is to cd to deps/openssl/config and run `make`, installing any needed packages until all architectures build correctly. Note that OpenSSL 1.1.1 does not support ASM on ARM64 Windows, so this change also supports only no-asm on ARM64 Windows. PR-URL: #26001 Fixes: #25998 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Signed-off-by: Beth Griggs <[email protected]>

This adds ARM64 Windows support in the OpenSSL build system. Since OpenSSL's ARM64 Windows support does not have support for ASM-- that is, VC-WIN64-ARM inherits from VC-noCE-common which has no ASM files--`openssl_no_asm.gypi` is always used for building. This essentially forces the 'no-asm' Configure flag. PR-URL: #26001 Fixes: #25998 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Signed-off-by: Beth Griggs <[email protected]>

This change adds the generated files required for building OpenSSL for Node.js for ARM64 Windows. I did this on a VM running Ubuntu 18.04. The basic workflow is to cd to deps/openssl/config and run `make`, installing any needed packages until all architectures build correctly. Note that OpenSSL 1.1.1 does not support ASM on ARM64 Windows, so this change also supports only no-asm on ARM64 Windows. PR-URL: #26001 Fixes: #25998 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Signed-off-by: Beth Griggs <[email protected]>

The toolchain for ARM64 Windows includes support for assembly code, but with a very different syntax from MASM and NASM. This change teaches GYP how to emit the right XML tags in VCXPROJ files to support compiling assembly files with the new tool. PR-URL: #26020 Refs: #25998 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: João Reis <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>

This adds ARM64 Windows support in the OpenSSL build system. Since OpenSSL's ARM64 Windows support does not have support for ASM-- that is, VC-WIN64-ARM inherits from VC-noCE-common which has no ASM files--`openssl_no_asm.gypi` is always used for building. This essentially forces the 'no-asm' Configure flag. PR-URL: nodejs#26001 Fixes: nodejs#25998 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Signed-off-by: Beth Griggs <[email protected]>

dennisameling · 2021-11-25T18:28:26Z

The team is waiting for machines they can use in their CI: nodejs/build#2540

For anyone who's interested, you can build NodeJS ARM64 yourself today by doing the following:

Install Wix Toolset 3.14
Fork/clone the NodeJS repo
git checkout v16.13.0 (or whatever version you want to build)
.\vcbuild.bat arm64 release msi

Currently, Windows ARM64 is "guaranteed to build" as it's in Tier 2 for compiling: https://github.com/nodejs/node/blob/master/BUILDING.md#strategy - so this should work without problems in future versions as well.

Here's a recent 16.13.0 build from a few days ago: https://github.com/dennisameling/node/releases/tag/v16.13.0-arm64

pb5050 · 2021-12-30T04:46:40Z

The team is waiting for machines they can use in their CI: nodejs/build#2540

For anyone who's interested, you can build NodeJS ARM64 yourself today by doing the following:

Install Wix Toolset 3.14

Fork/clone the NodeJS repo

git checkout v16.13.0 (or whatever version you want to build)

.\vcbuild.bat arm64 release msi

Currently, Windows ARM64 is "guaranteed to build" as it's in Tier 2 for compiling: https://github.com/nodejs/node/blob/master/BUILDING.md#strategy - so this should work without problems in future versions as well.

Here's a recent 16.13.0 build from a few days ago: https://github.com/dennisameling/node/releases/tag/v16.13.0-arm64

you great a great grreat contributor i see you everywhere windows should pay you for all the work and advancement you have done for windows on arm

keep it up! you inspire

pb5050 · 2022-01-19T21:07:56Z

Thankyou for your continued support for Windows ARM64. Will you be publishing a pre built installer at https://nodejs.org/en/download/ ?

any plans on this? seems like its time

hajekj · 2022-04-05T05:57:18Z

I believe obtaining build agents should now be much more easier thanks to Arm-based processors coming to Azure: https://azure.microsoft.com/en-us/blog/now-in-preview-azure-virtual-machines-with-ampere-altra-armbased-processors/

If needed I can provide a part of my subscription to host the required VMs.

If you need to get in touch with me regarding this, please reach out at: [email protected]

nonsenseless · 2022-07-20T21:18:11Z

Install Wix Toolset 3.14

Fork/clone the NodeJS repo

git checkout v16.13.0 (or whatever version you want to build)

.\vcbuild.bat arm64 release msi

@dennisameling Thank you for the notes! I was able to install wix 3.14 and added a path variable for WIX, but I'm wondering if there are any other environment config steps I should be aware of? I'm getting the following error running the script:

Looking for Python
Python found in C:\Python310\\python.exe
Looking for Visual Studio 2019
Looking for Visual Studio 2017
Looking for WiX installation for Visual Studio 2017...
Failed to find the WiX Toolset Visual Studio 2017 Extension
Failed to find a suitable Visual Studio installation.
Try to run in a "Developer Command Prompt" or consult
https://github.com/nodejs/node/blob/HEAD/BUILDING.md#windows

and I'm afraid to dick around with vcbat much further since (I believe) VS 2022 is the first version to support arm64. The error seems to be tied to VCINSTALLDIR being null; do you have any idea what might be going wrong?

Edit: The same thing happens whether I try running from cmd, a developer prompt launched by visual studio, git bash, or power shell.

sxa · 2022-07-21T08:41:56Z

@nonsenseless Which VS version do you have installed? We've built it with 2019 without problems so if you have that and it's not detected that would be a problem (VS2019 what's on our build machines)

richardlau · 2022-07-21T10:48:39Z

Not sure whether ARM64 differs, but on x64 you need both the Wix Toolset and the WiX Toolset Visual Studio Extension (we're using the VS 2019 version in our CI).

nonsenseless · 2022-07-21T16:29:10Z

@richardlau I went back and I realize that when I tried to install VS2019 and it gave me a stability warning about not being supported on ARM64 I interpreted that as "You can't install this" instead of as "Good luck". I pressed through, installed, added the wix extension for 2019, and then the build steps worked for the version I'd pulled down. Thank you for your help!

jkunkee · 2022-07-21T16:58:23Z

I'm happy to hear you're making progress, @nonsenseless!

since (I believe) VS 2022 is the first version to support arm64
it gave me a stability warning about not being supported on ARM64
"Good luck"

Got there in the end. The VS team would have worded that carefully to help forestall perf and functionality bugs that their dev and triage processes was not equipped to handle. "Good luck" is the right interpretation, though it could also be seen as "yes, we know it's slow, no, it's not a bug" or "we won't chase down broken corner cases if there are any." The goal of the x86 and x64 emulators is that apps--even ones as complex as VS--just work, unmodified. :)

As you've figured out, VS 2022 is the first to officially support running on ARM64. On ARM64 Windows 11 (which has the ARM64 and x64 .NET Frameworks as well as x86), devenv.exe, msbuild.exe, cl.exe, csc.exe--everything runs natively without emulation. (You can use varargs.cmd to force the use of x64- or x86-hosted tools just as on x64; they'll just run slower.)

IIRC, VS has supported generating ARM64 code officially since VS 2019, with experimental support introduced later in VS 2017. (I believe I used VS 2017 to bootstrap the Node.js build for ARM64 Windows.)

VS 2022 is also getting support for ARM64EC, an emulation-compatible native ABI. There are some fun possibilities here for Node.js (think native ARM64 JIT with x64 binary module compat), but they are neither trivial nor salient to this thread. :)

Needed for ARM, which is presently not supported by prebuildify due to lack of official node builds: nodejs/node#25998

github-actions · 2023-01-18T01:28:51Z

There has been no activity on this feature request for 5 months and it is unlikely to be implemented. It will be closed 6 months after the last non-automated comment.

For more information on how the project manages feature requests, please consult the feature request management document.

Alovchin91 · 2023-01-18T07:52:31Z

Nope, not so fast! By now you have everything in place to implement this.

Blackhex · 2023-01-20T16:49:52Z

We are also looking into this. So far only #46231 and #46420 seem to be issues to compile Node on Windows ARM64 with VS 2022.

joespeed · 2023-02-05T16:10:39Z

fixed per @eukarpov #46231 (comment)

sxa · 2023-02-06T10:58:28Z

Note that in terms of activity on this front, most of the discussion has been happening over in nodejs/build#3046 and it is being built as part of our regular CI runs - it just hasn't made it to being a production release platform yet.

Refs: nodejs/build#3046 Refs: nodejs/build#2540 Fixes: nodejs#25998

Refs: nodejs/build#3046 Refs: nodejs/build#2540 Fixes: #25998 PR-URL: #47233 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

jkunkee mentioned this issue Feb 8, 2019

openssl: add arm64 Windows config files #26001

Closed

2 tasks

ChALkeR added arm Issues and PRs related to the ARM platform. windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. labels Feb 8, 2019

jkunkee mentioned this issue Feb 13, 2019

deps: get new v8 building for ARM64 Windows #26087

Closed

2 tasks

jkunkee mentioned this issue Feb 22, 2019

Add ARM64 Windows tool option felixrieseberg/windows-build-tools#176

Merged

kaadam mentioned this issue Feb 25, 2019

configure: Enable ARM64 single-toolchain build on Windows nodejs/node-gyp#1678

Closed

4 tasks

BridgeAR closed this as completed in a19e8eb Apr 4, 2019

joaocgreis reopened this Apr 4, 2019

jasnell closed this as completed in nodejs/quic@e575ba6 Apr 29, 2019

targos added this to Node.js feature requests Apr 4, 2022

targos moved this to Pending Triage in Node.js feature requests Apr 4, 2022

simonbuchan mentioned this issue Jul 16, 2022

ARM64 support simonbuchan/native-reg#34

Closed

simonbuchan added a commit to simonbuchan/native-reg that referenced this issue Jul 22, 2022

Re-enable node-gyp-build as fallback.

2627e8b

Needed for ARM, which is presently not supported by prebuildify due to lack of official node builds: nodejs/node#25998

github-actions bot added the stale label Jan 18, 2023

github-actions bot removed the stale label Jan 19, 2023

StefanStojanovic mentioned this issue Feb 22, 2023

win,src: revert simdutf to icu for win arm64 #46780

Closed

StefanStojanovic added a commit to JaneaSystems/node that referenced this issue Mar 23, 2023

doc: make win arm64 tier 2 platform

1235d11

Refs: nodejs/build#3046 Refs: nodejs/build#2540 Fixes: nodejs#25998

StefanStojanovic mentioned this issue Mar 23, 2023

Upgrading Windows on ARM64 to a tier 2 platform #47233

Merged

nodejs-github-bot closed this as completed in #47233 Mar 30, 2023

RedYetiDev moved this from Awaiting Triage to Done in Node.js feature requests Aug 18, 2024

RedYetiDev removed this from Node.js feature requests Sep 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support ARM64 Windows desktop #25998

Support ARM64 Windows desktop #25998

jkunkee commented Feb 7, 2019

jkunkee commented Feb 8, 2019 •

edited

Loading

refack commented Feb 8, 2019

jkunkee commented Feb 8, 2019

jkunkee commented Feb 8, 2019

jkunkee commented Feb 9, 2019

jefgen commented Feb 11, 2019

jkunkee commented Feb 11, 2019

jkunkee commented Feb 11, 2019

jkunkee commented Feb 19, 2019 •

edited

Loading

dennisameling commented Nov 25, 2021 •

edited

Loading

pb5050 commented Dec 30, 2021 •

edited

Loading

pb5050 commented Jan 19, 2022

hajekj commented Apr 5, 2022 •

edited

Loading

nonsenseless commented Jul 20, 2022 •

edited

Loading

sxa commented Jul 21, 2022

richardlau commented Jul 21, 2022

nonsenseless commented Jul 21, 2022

jkunkee commented Jul 21, 2022

github-actions bot commented Jan 18, 2023

Alovchin91 commented Jan 18, 2023

Blackhex commented Jan 20, 2023 •

edited

Loading

joespeed commented Feb 5, 2023

sxa commented Feb 6, 2023

Support ARM64 Windows desktop #25998

Support ARM64 Windows desktop #25998

Comments

jkunkee commented Feb 7, 2019

jkunkee commented Feb 8, 2019 • edited Loading

refack commented Feb 8, 2019

jkunkee commented Feb 8, 2019

jkunkee commented Feb 8, 2019

jkunkee commented Feb 9, 2019

jefgen commented Feb 11, 2019

jkunkee commented Feb 11, 2019

jkunkee commented Feb 11, 2019

jkunkee commented Feb 19, 2019 • edited Loading

dennisameling commented Nov 25, 2021 • edited Loading

pb5050 commented Dec 30, 2021 • edited Loading

pb5050 commented Jan 19, 2022

hajekj commented Apr 5, 2022 • edited Loading

nonsenseless commented Jul 20, 2022 • edited Loading

sxa commented Jul 21, 2022

richardlau commented Jul 21, 2022

nonsenseless commented Jul 21, 2022

jkunkee commented Jul 21, 2022

github-actions bot commented Jan 18, 2023

Alovchin91 commented Jan 18, 2023

Blackhex commented Jan 20, 2023 • edited Loading

joespeed commented Feb 5, 2023

sxa commented Feb 6, 2023

jkunkee commented Feb 8, 2019 •

edited

Loading

jkunkee commented Feb 19, 2019 •

edited

Loading

dennisameling commented Nov 25, 2021 •

edited

Loading

pb5050 commented Dec 30, 2021 •

edited

Loading

hajekj commented Apr 5, 2022 •

edited

Loading

nonsenseless commented Jul 20, 2022 •

edited

Loading

Blackhex commented Jan 20, 2023 •

edited

Loading