Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deprecating WindowControls which is not working a few versions a lready #1439

Merged
merged 1 commit into from
Jul 24, 2024
Merged

fix: deprecating WindowControls which is not working a few versions a lready #1439

merged 1 commit into from
Jul 24, 2024

Conversation

djelinek
Copy link
Collaborator

Window Control is no more available in a DOM of Visual Studio Code

Before submitting your PR, please review the following checklist:

  • CONSIDER adding a new test if your PR resolves an issue.
  • DO keep pull requests small so they can be easily reviewed.
  • DO make sure tests pass.
  • DO make sure any public APIs changes are documented.
  • DO make sure not to introduce any compiler warnings.

Before merging the PR:

  • CHECK continuous integration of main branch is green.
  • CHECK pull request check job is green.
  • CHECK all pull request questions/requests are resolved.
  • WAIT till PR is approved by at least 1 committer.

@djelinek
fix: deprecating WindowControls which is not working a few versions a…
4ca4e8a 
…lready

Window Control is no more available in a DOM of Visual Studio Code

Signed-off-by: Dominik Jelinek <[email protected]>
@djelinek djelinek added the bug Something isn't working label Jul 24, 2024
@djelinek djelinek linked an issue Jul 24, 2024 that may be closed by this pull request
[🚫 Bug] windowControls seems not working #1117
Closed
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 24, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
8 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@djelinek djelinek marked this pull request as ready for review July 24, 2024 21:09
@djelinek djelinek merged commit b2904f7 into redhat-developer:main Jul 24, 2024
12 checks passed
lgrossma pushed a commit to lgrossma/vscode-extension-tester that referenced this pull request Aug 1, 2024
@djelinek
fix: deprecating WindowControls which is not working a few versions a…
d954047 
… lready (redhat-developer#1439)

Signed-off-by: Dominik Jelinek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🚫 Bug] windowControls seems not working
1 participant
@djelinek