Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚫 Bug] windowControls seems not working #1117

Closed
NevEinsit opened this issue Feb 7, 2024 · 1 comment · Fixed by #1439
Closed

[🚫 Bug] windowControls seems not working #1117

NevEinsit opened this issue Feb 7, 2024 · 1 comment · Fixed by #1439
Assignees
Labels
bug Something isn't working
Milestone

Comments

@NevEinsit
Copy link

Describe the bug

Hello,

We tried to maximize the VSCode instance because we need TitleBarItems that are not visible in a normal sized VSCode instance. But we found that we cannot maximize the VSCode instance by the control.

Please see more details in steps to reproduce. Thanks!

Steps to reproduce

Code snippet:
`
const controls = new TitleBar().getWindowControls();
await controls.restore();
await new Promise((f) => setTimeout(f, 3000));
await controls.maximize();
await new Promise((f) => setTimeout(f, 3000));
await controls.restore();
await new Promise((f) => setTimeout(f, 3000));
await controls.maximize();
await new Promise((f) => setTimeout(f, 3000));
`
While running the test, observe the VSCode test instance, it's not resized. But I can still click on the buttons to perform maximize and restore manually.

Logs

Window is not maximized
Window is already maximized
Window is not maximized
Window is already maximized

Operating System

Windows 10, Ubuntu 22.04

Visual Studio Code

1.85.0

vscode-extension-tester

7.0.0

NodeJS

18.15.0

npm

No response

@NevEinsit NevEinsit added bug Something isn't working new-issue New issue which was not discussed yet labels Feb 7, 2024
@djelinek djelinek added this to the NEXT milestone Feb 9, 2024
@djelinek djelinek removed the new-issue New issue which was not discussed yet label Feb 9, 2024
@djelinek djelinek self-assigned this Jul 24, 2024
@djelinek
Copy link
Collaborator

unfortunately this cannot be fixed 🙁 . The Window Control is no more available in a DOM of Visual Studio Code at all.

The WindowControls page object will be deprecated.

@djelinek djelinek moved this from Todo to In Progress in ExTester Jul 24, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in ExTester Jul 24, 2024
@djelinek djelinek modified the milestones: NEXT, 8.5.0 Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
2 participants