Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tests with examples from gitops-operator repo #573

Merged

Conversation

anandrkskd
Copy link
Contributor

@anandrkskd anandrkskd commented Jul 20, 2023

NOTE: This is PR requires #559 to be merged first

What type of PR is this?

/kind enhancement

What does this PR do / why we need it:
This PR updates the tests to use examples from gitops-operator repo.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes GITOPS-2690

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

**NOTE: this is PR requires #559 to be merged first **

  • connect to a cluster with latest gitops operator installed
  • to run the tests, execute
kubectl kuttl test ./test/openshift/e2e/parallel/  --config ./test/openshift/e2e/parallel/kuttl-test.yaml  \
--test <TEST_DIR_NAME>

example:

kubectl kuttl test ./test/openshift/e2e/parallel/  --config ./test/openshift/e2e/parallel/kuttl-test.yaml --test 1-102_validate_handle_terminating_namespaces

@openshift-ci openshift-ci bot added the kind/enhancement New feature or request label Jul 20, 2023
@openshift-ci openshift-ci bot requested review from trdoyle81 and wtam2018 July 20, 2023 05:37
@anandrkskd
Copy link
Contributor Author

/retest

Signed-off-by: ansingh <[email protected]>
@anandrkskd anandrkskd force-pushed the test/centralize_resource2 branch from 8c13b2f to 9aa0286 Compare July 28, 2023 06:26
@varshab1210
Copy link
Member

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jul 28, 2023

@anandrkskd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.11-kuttl-parallel 14f64ae link true /test v4.11-kuttl-parallel
ci/prow/v4.10-kuttl-parallel 14f64ae link true /test v4.10-kuttl-parallel
ci/prow/v4.12-kuttl-parallel 14f64ae link true /test v4.12-kuttl-parallel

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@iam-veeramalla
Copy link
Collaborator

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iam-veeramalla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@anandrkskd
Copy link
Contributor Author

1-054_validate_deploymentconfig is failing as the test as its trying to change targetRevision that is not present in this repo, we are adding another example here that will be used in the test instead and thus will fix the tests from failing.

@iam-veeramalla iam-veeramalla merged commit 38b717a into redhat-developer:master Jul 31, 2023
trdoyle81 pushed a commit to trdoyle81/gitops-operator that referenced this pull request Aug 13, 2024
…ze_resource2

update tests with examples from gitops-operator repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants