Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GITOPS-2690 adding all the example used in testing from different sources #559

Conversation

anandrkskd
Copy link
Contributor

@anandrkskd anandrkskd commented Jul 11, 2023

What type of PR is this?

/kind enhancement

What does this PR do / why we need it:

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes GITOPS-2690

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

@anandrkskd
Copy link
Contributor Author

/test v4.10-kuttl-sequential

@varshab1210
Copy link
Member

Hi @anandrkskd
I see there are some additional tests like 1-083_validate_kustomize_namereference that's still using personal account. Can you please address them as well?

@anandrkskd
Copy link
Contributor Author

/test v4.11-kuttl-parallel v4.10-kuttl-parallel v4.12-kuttl-parallel

@anandrkskd
Copy link
Contributor Author

Some tests are failing with

        +  - lastTransitionTime: "2023-07-18T07:13:53Z"
        +    message: 'rpc error: code = Unknown desc = Manifest generation error (cached):
        +      test/examples/kustomize-guestbook: app path does not exist'

As the tests are pointed to HEAD for example path,
We can merge this PR without modification to the tests and then make changes to test on a separate PR to test if the tests are working as expected or not.
@varshab1210 @trdoyle81 @iam-veeramalla, WDYT?

@anandrkskd anandrkskd force-pushed the test/centralize_resource branch from f0c8fcb to 9c2f211 Compare July 18, 2023 12:22
@anandrkskd
Copy link
Contributor Author

/test ci/prow/v4.10-e2e

@openshift-ci
Copy link

openshift-ci bot commented Jul 19, 2023

@anandrkskd: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test unit
  • /test v4.10-ci-index-gitops-operator-bundle
  • /test v4.10-e2e
  • /test v4.10-images
  • /test v4.10-kuttl-parallel
  • /test v4.10-kuttl-sequential
  • /test v4.11-ci-index-gitops-operator-bundle
  • /test v4.11-e2e
  • /test v4.11-images
  • /test v4.11-kuttl-parallel
  • /test v4.11-kuttl-sequential
  • /test v4.12-ci-index-gitops-operator-bundle
  • /test v4.12-e2e
  • /test v4.12-images
  • /test v4.12-kuttl-parallel
  • /test v4.12-kuttl-sequential

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-redhat-developer-gitops-operator-master-unit
  • pull-ci-redhat-developer-gitops-operator-master-v4.10-e2e
  • pull-ci-redhat-developer-gitops-operator-master-v4.10-kuttl-parallel
  • pull-ci-redhat-developer-gitops-operator-master-v4.10-kuttl-sequential
  • pull-ci-redhat-developer-gitops-operator-master-v4.11-ci-index-gitops-operator-bundle
  • pull-ci-redhat-developer-gitops-operator-master-v4.11-e2e
  • pull-ci-redhat-developer-gitops-operator-master-v4.11-images
  • pull-ci-redhat-developer-gitops-operator-master-v4.11-kuttl-parallel
  • pull-ci-redhat-developer-gitops-operator-master-v4.11-kuttl-sequential
  • pull-ci-redhat-developer-gitops-operator-master-v4.12-ci-index-gitops-operator-bundle
  • pull-ci-redhat-developer-gitops-operator-master-v4.12-e2e
  • pull-ci-redhat-developer-gitops-operator-master-v4.12-images
  • pull-ci-redhat-developer-gitops-operator-master-v4.12-kuttl-parallel
  • pull-ci-redhat-developer-gitops-operator-master-v4.12-kuttl-sequential

In response to this:

/test ci/prow/v4.10-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@anandrkskd
Copy link
Contributor Author

/test v4.10-e2e

1 similar comment
@anandrkskd
Copy link
Contributor Author

/test v4.10-e2e

Signed-off-by: ansingh <[email protected]>
@anandrkskd
Copy link
Contributor Author

/test v4.11-kuttl-sequential

@trdoyle81
Copy link
Contributor

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jul 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Jul 27, 2023
@mehabhalodiya
Copy link
Contributor

It's just a rebase, so adding the label again.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 27, 2023
@openshift-merge-robot openshift-merge-robot merged commit 9f471f3 into redhat-developer:master Jul 27, 2023
trdoyle81 pushed a commit to trdoyle81/gitops-operator that referenced this pull request Aug 13, 2024
…rces (redhat-developer#559)

* adding gitops test example

Signed-off-by: ansingh <[email protected]>

* adding doc

Signed-off-by: ansingh <[email protected]>

---------

Signed-off-by: ansingh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants