-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump react to v17.x #275
Merged
Merged
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ce7e498
chore(deps): bump react to v17.x
rafegoldberg 869c3ef
test: against react v16 + 17
rafegoldberg 7085e28
fix(peerdeps): typo
rafegoldberg 08af24f
chore(devDeps): instal enzyme/React v17 adapter
rafegoldberg d3f49e7
Merge branch 'chore/deps/bump-react-to-v17.x' of github.com:readmeio/…
rafegoldberg e2c0b64
feat: getting ci building against react 16
erunion 3c3b1f1
ci: fixes
erunion 5c75a94
ci: debugging
erunion e80edb0
ci: debugging
erunion 7c5483d
ci: debugging
erunion 7ebf512
ci: drop support for node 12
erunion 91d3908
ci: run tests
erunion 44a4415
fix: linting issues
erunion a2c13f8
ci: cleaning up messaging
erunion 6b8d657
Merge branch 'main' into chore/deps/bump-react-to-v17.x
erunion File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,7 +9,10 @@ jobs: | |
|
||
strategy: | ||
matrix: | ||
node-version: [12.x, 14.x] | ||
node-version: [14.x, 16.x] | ||
react: [16, 17] | ||
|
||
name: build (${{ matrix.node-version }} w/ React ${{ matrix.react }} | ||
|
||
steps: | ||
- uses: actions/[email protected] | ||
|
@@ -25,5 +28,19 @@ jobs: | |
- name: Install dependencies | ||
run: npm ci | ||
|
||
- name: Install React v${{ matrix.react }} | ||
run: npm i react@${{ matrix.react }} react-dom@${{ matrix.react }} | ||
|
||
- name: Install React 16 Enzyme adapter | ||
if: matrix.react == '16' | ||
run: | | ||
npm remove @wojtekmaj/enzyme-adapter-react-17 | ||
npm install enzyme-adapter-react-16 | ||
|
||
- name: Run tests | ||
if: matrix.react == '16' | ||
run: REACT_VERSION=16 npm test | ||
|
||
- name: Run tests | ||
if: matrix.react == '17' | ||
run: npm test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this when we're doing React 16 because NPM might throw issues with it wanting React 17 to be around.