chore(deps): bump react to v17.x #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [x] update to react to v17.x - [x] update react peer deps to v16 or 17 - [x] [update enzyme adapter for react v17][ref1] [ref1]: https://semver.npmjs.com/
rafegoldberg
requested review from
erunion,
a team,
Dashron and
gratcliff
and removed request for
a team
gratcliff
reviewed
Mar 29, 2022
rafegoldberg
commented
Mar 29, 2022
should be "17.x" not "7.x"!
Co-authored-by: Gabe <[email protected]>
…syntax-highlighter into chore/deps/bump-react-to-v17.x
erunion
reviewed
Mar 29, 2022
| @@ -10,6 +10,9 @@ | |||
| "url": "https://github.com/readmeio/syntax-highlighter.git" | |||
| }, | |||
| "homepage": "https://readmeio.github.io/syntax-highlighter/", | |||
| "engines": { | |||
| "node": "^14 || ^16" | |||
There was a problem hiding this comment.
Since we're introducing React 17 support in this we might as well make this a major release and formally deprecate Node 12 support while we're at it.
There was a problem hiding this comment.
That sounds about right to me!
erunion
reviewed
Mar 29, 2022
| @@ -64,11 +67,6 @@ | |||
| "webpack-dev-server": "^4.2.1" | |||
| }, | |||
| "prettier": "@readme/eslint-config/prettier", | |||
| "husky": { | |||
erunion
reviewed
Mar 29, 2022
| - name: Install React 16 Enzyme adapter | ||
| if: matrix.react == '16' | ||
| run: | | ||
| npm remove @wojtekmaj/enzyme-adapter-react-17 |
There was a problem hiding this comment.
Removing this when we're doing React 16 because NPM might throw issues with it wanting React 17 to be around.
erunion
approved these changes
Mar 29, 2022
There was a problem hiding this comment.
Tests are all passing on react 16 and 17 in CI now so merge this whenever you want to @rafegoldberg and I'll tag a new release.
rafegoldberg
commented
Mar 29, 2022
Comment on lines
5
to
10
| let Adapter; | ||
| if (process.env.REACT_VERSION && process.env.REACT_VERSION == '16') { | ||
| Adapter = require('enzyme-adapter-react-16'); | ||
| } else { | ||
| Adapter = require('@wojtekmaj/enzyme-adapter-react-17'); | ||
| } |
| @@ -10,6 +10,9 @@ | |||
| "url": "https://github.com/readmeio/syntax-highlighter.git" | |||
| }, | |||
| "homepage": "https://readmeio.github.io/syntax-highlighter/", | |||
| "engines": { | |||
| "node": "^14 || ^16" | |||
There was a problem hiding this comment.
That sounds about right to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
🧪 Testing
If tests pass when run against both React v16 and 17, this worked!