Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Bump Gymnasium to 0.28.1 #35698

Merged
merged 70 commits into from
Jul 31, 2023
Merged

[RLlib] Bump Gymnasium to 0.28.1 #35698

merged 70 commits into from
Jul 31, 2023

Conversation

Rohan138
Copy link
Contributor

@Rohan138 Rohan138 commented May 24, 2023 •
edited
Loading

Why are these changes needed?

Related issue number

#34396 #32999 #31587

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

bump to 0.28.1
9dd8b29 
Signed-off-by: Rohan Potdar <[email protected]>
@Rohan138 Rohan138 mentioned this pull request May 24, 2023
Closed
@ArturNiederfahrenhorst ArturNiederfahrenhorst mentioned this pull request May 24, 2023
Closed
@elliottower elliottower mentioned this pull request May 25, 2023
Closed
8 tasks
@Rohan138 Rohan138 requested a review from a team as a code owner June 5, 2023 19:41
@sven1977
wip
264c836 
Signed-off-by: sven1977 <[email protected]>
@sven1977 sven1977 changed the title [RLlib] bump Gymnasium to 0.28.1 [RLlib] Bump Gymnasium to 0.28.1 Jul 28, 2023
ericl
ericl approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@ericl ericl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamping

@ArturNiederfahrenhorst
Copy link
Contributor

Another related issue: #37393

@sven1977
wip
51d53f0 
Signed-off-by: sven1977 <[email protected]>
@ArturNiederfahrenhorst
Copy link
Contributor

@sven1977 I'm adding a PR ontop of this to revamp our video-recording capabilities: #37922

@XavierGeerinck
Copy link

Thank you so much for this PR! Can't wait for it to get merged as we are heavily waiting on this as well. Just a quick question, would it be feasible to go straight to the latest version then as well? (0.29.0 is out meanwhile)

@araffin araffin mentioned this pull request Jul 31, 2023
Closed
4 tasks
@sven1977
Copy link
Contributor

Thank you so much for this PR! Can't wait for it to get merged as we are heavily waiting on this as well. Just a quick question, would it be feasible to go straight to the latest version then as well? (0.29.0 is out meanwhile)

Thanks for the hint: Trying tests again with 0.29.0. If all tests pass, we'll upgrade to 0.29.0, if not, we'll do 0.28.1 for now and upgrade to 0.29.0 later.

@sven1977 sven1977 mentioned this pull request Jul 31, 2023
Open
@sven1977 sven1977 merged commit 6f88b0c into ray-project:master Jul 31, 2023
@ChrisMcCarthyDev
Copy link

Thank you for the effort that's went into this! Is there a proposed release date?

@ChrisMcCarthyDev ChrisMcCarthyDev mentioned this pull request Aug 1, 2023
Closed
@can-anyscale can-anyscale mentioned this pull request Aug 1, 2023
Merged
@ArturNiederfahrenhorst
Copy link
Contributor

@ChrisMcCarthyDev Around three weeks.

ArturNiederfahrenhorst added a commit to ArturNiederfahrenhorst/ray that referenced this pull request Aug 3, 2023
@ArturNiederfahrenhorst
Revert "[RLlib] Bump Gymnasium to 0.28.1 (ray-project#35698)"
08c6965 
This reverts commit 6f88b0c.
ArturNiederfahrenhorst added a commit to ArturNiederfahrenhorst/ray that referenced this pull request Aug 3, 2023
@ArturNiederfahrenhorst
Revert "Revert "[RLlib] Bump Gymnasium to 0.28.1 (ray-project#35698)""
2593e8e 
This reverts commit 08c6965.
NripeshN pushed a commit to NripeshN/ray that referenced this pull request Aug 15, 2023
@Rohan138 @NripeshN
[RLlib] Bump Gymnasium to 0.28.1 (ray-project#35698)
759aec8 
Signed-off-by: NripeshN <[email protected]>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@Rohan138 @arvind-chandra
[RLlib] Bump Gymnasium to 0.28.1 (ray-project#35698)
a65ebf2 
Signed-off-by: e428265 <[email protected]>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
@Rohan138
[RLlib] Bump Gymnasium to 0.28.1 (ray-project#35698)
a7f059f 
Signed-off-by: Victor <[email protected]>
@t-gonsalves t-gonsalves mentioned this pull request Feb 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliottower elliottower elliottower left review comments

@sven1977 sven1977 sven1977 approved these changes

@araffin araffin araffin left review comments

@shrekris-anyscale shrekris-anyscale shrekris-anyscale approved these changes

@kouroshHakha kouroshHakha kouroshHakha approved these changes

@ArturNiederfahrenhorst ArturNiederfahrenhorst ArturNiederfahrenhorst approved these changes

@maxpumperla maxpumperla maxpumperla approved these changes

@ericl ericl ericl approved these changes

@gjoliver gjoliver Awaiting requested review from gjoliver

@avnishn avnishn Awaiting requested review from avnishn

@smorad smorad Awaiting requested review from smorad

@krfricke krfricke Awaiting requested review from krfricke

@richardliaw richardliaw Awaiting requested review from richardliaw richardliaw is a code owner

@edoakes edoakes Awaiting requested review from edoakes edoakes is a code owner

@sihanwang41 sihanwang41 Awaiting requested review from sihanwang41

@zcin zcin Awaiting requested review from zcin zcin is a code owner

@architkulkarni architkulkarni Awaiting requested review from architkulkarni

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.