Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] relax gymnasium requirement #34396

Closed
duburcqa opened this issue Apr 14, 2023 · 9 comments
Closed

[RLlib] relax gymnasium requirement #34396

duburcqa opened this issue Apr 14, 2023 · 9 comments
Assignees
Labels
enhancement Request for new feature and/or capability P1 Issue that should be fixed within a few weeks

Comments

@duburcqa
Copy link
Contributor

Description

Would it be possible to relax gymnasium requirement to gymnasium >= 0.26.3, <=0.28.1 ? This is necessary to be compatible with stable-baseline3. See DLR-RM/stable-baselines3#1452.

Use case

No response

@duburcqa duburcqa added enhancement Request for new feature and/or capability triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Apr 14, 2023
@ArturNiederfahrenhorst
Copy link
Contributor

Hi @duburcqa ,

That's not possible "just like that".
I have an open draft PR that attempts to upgrade to 0.27.x I believe.
We'll definitely upgrade at some point.
Could you specify how urgent this is and what the use case is?

@ArturNiederfahrenhorst ArturNiederfahrenhorst added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Apr 14, 2023
@duburcqa
Copy link
Contributor Author

duburcqa commented Apr 14, 2023

That's not possible "just like that".
I have an open draft PR that attempts to upgrade to 0.27.x I believe.

Ok I see, it is a bad news but not surprising...

Could you specify how urgent this is and what the use case is?

Nothing especially urgent. It just does not exist any version of ray[rllib] and stable-baselines3 that are compatible with each other, at least for python 3.11. This incompatibility makes it difficult for package maintainers of gym environments to write unit tests and provide examples for the most common learning frameworks.

@ArturNiederfahrenhorst ArturNiederfahrenhorst added P1 Issue that should be fixed within a few weeks and removed @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. labels Apr 19, 2023
@ArturNiederfahrenhorst
Copy link
Contributor

@Rohan138 Can you take a look? I have an open PR for reference
#32999

@ArturNiederfahrenhorst ArturNiederfahrenhorst removed the triage Needs triage (eg: priority, bug/not-bug, and owning component) label Apr 19, 2023
@duburcqa
Copy link
Contributor Author

Any update on this point ?

@Rohan138
Copy link
Contributor

@duburcqa I see that stable-baselines3 is now pinned to the latest gymnasium==0.28.1 release; we will try to update to the same in #32999, however, this will take time. In the meanwhile, I would recommend installing ray and stable-baselines3 in separate environments, since stable-baselines3 does not work with previous versions of gymnasium.

@duburcqa
Copy link
Contributor Author

Thank you for the update. I could create separate environments but it does not really solve the issue because I'm maintaining a library offering a suite of learning environment and having to be compatible with multiple versions of gym that seems to be partial incompatible with each other is less than ideal.

@Rohan138
Copy link
Contributor

I'll get this PR merged soon, should update to gymnasium=0.28.1. #35698

Thank you for raising this issue!

@duburcqa
Copy link
Contributor Author

Any update ?

@Rohan138
Copy link
Contributor

@duburcqa See the PR in #35698; we're currently trying to figure out a mujoco versioning issue that's breaking our tests when we try to upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request for new feature and/or capability P1 Issue that should be fixed within a few weeks
Projects
None yet
Development

No branches or pull requests

3 participants