Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read marker no more aligned with Riot's #210

Closed
KitsuneRal opened this issue Nov 19, 2017 · 3 comments
Closed

Read marker no more aligned with Riot's #210

KitsuneRal opened this issue Nov 19, 2017 · 3 comments
Assignees
@KitsuneRal
Labels
bug/fix Quaternion doesn't work as expected

Comments

@KitsuneRal
Copy link
Member

I suppose this is because of the implemented ReadMarker API that introduced an official cross-device read marker stored in account data. Depends on quotient-im/libQuotient#123.
@KitsuneRal KitsuneRal added the bug/fix Quaternion doesn't work as expected label Nov 21, 2017
@KitsuneRal KitsuneRal added this to the 0.1 milestone Dec 26, 2017
@KitsuneRal KitsuneRal removed this from the 0.1 milestone Jan 9, 2018
@krombel
Copy link
Contributor

krombel commented Jan 17, 2018

There are two steps: sending and reading.
The later one depends on quotient-im/libQuotient#123.

But what's about sending?
For this the read marker with m.fully_read should be send.

@KitsuneRal KitsuneRal mentioned this issue Jan 17, 2018
Closed
@KitsuneRal KitsuneRal self-assigned this Feb 25, 2018
@KitsuneRal
Copy link
Member Author

Pre-spec, according to which Riot works, for the record: https://docs.google.com/document/d/1UWqdS-e1sdwkLDUY0wA4gZyIkRp-ekjsLZ8k6g_Zvso

@KitsuneRal
Copy link
Member Author

Also, the spec issue: matrix-org/matrix-spec-proposals#910

@KitsuneRal KitsuneRal mentioned this issue Mar 5, 2018
Closed
nicolasfella pushed a commit to nicolasfella/Quaternion that referenced this issue Dec 27, 2020
@KitsuneRal
BaseJob::setStatus: Don't try to remove access token if it's empty
7e15f82 
Closes quotient-im#210.
@KitsuneRal KitsuneRal moved this to Version 0.0.9 - Released in Quaternion 1 Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KitsuneRal KitsuneRal

Labels
bug/fix Quaternion doesn't work as expected
Projects
Quaternion 1
Status: Version 0.0.9 - Released
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KitsuneRal @krombel