Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new Read Marker API to docs #910

Closed
lukebarnard1 opened this issue May 8, 2017 · 1 comment
Closed

Add new Read Marker API to docs #910

lukebarnard1 opened this issue May 8, 2017 · 1 comment
Assignees
@turt2live
Labels
kind:feature MSC for not-core and not-maintenance stuff merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal spec-omission implemented but not currently specified

Comments

@lukebarnard1
Copy link

lukebarnard1 commented May 8, 2017 •
edited by ara4n
Loading

Documentation: https://docs.google.com/document/d/1UWqdS-e1sdwkLDUY0wA4gZyIkRp-ekjsLZ8k6g_Zvso/edit

SPEC: Synapse changes here, matrix-org/synapse#2120
JS-SDK changes: https://github.com/matrix-org/matrix-js-sdk/pull/419/files
@richvdh richvdh added the spec-omission implemented but not currently specified label May 8, 2017
@turt2live
Copy link
Member

More information: https://docs.google.com/document/d/1UWqdS-e1sdwkLDUY0wA4gZyIkRp-ekjsLZ8k6g_Zvso/edit

@turt2live turt2live mentioned this issue Oct 18, 2017
Merged
@KitsuneRal KitsuneRal mentioned this issue Feb 27, 2018
Closed
@benparsons benparsons added proposal-passed-review spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed proposal-passed-review labels May 10, 2018
@ara4n ara4n added the proposal A matrix spec change proposal label May 15, 2018
@turt2live turt2live self-assigned this Aug 22, 2018
turt2live added a commit to turt2live/matrix-doc that referenced this issue Aug 30, 2018
@turt2live
Add read markers
f923d08 
This is the spec for matrix-org#910

Fixes matrix-org#910

Some reverse engineering was required to work out the complete details as to how this works. In particular, the 405 for setting account data and the behaviour of m.read.

References:
* 405 for account data: https://github.com/matrix-org/synapse/blob/d69decd5c78c72abef50b597a689e2bc55a39702/synapse/rest/client/v2_alpha/account_data.py#L85-L90
* m.read behaviour: https://github.com/matrix-org/synapse/blob/d69decd5c78c72abef50b597a689e2bc55a39702/synapse/rest/client/v2_alpha/read_marker.py#L45-L52
@turt2live turt2live mentioned this issue Aug 30, 2018
Merged
@richvdh richvdh added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Aug 31, 2018
@uhoreg uhoreg added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Sep 17, 2018
@turt2live turt2live added the kind:feature MSC for not-core and not-maintenance stuff label Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
kind:feature MSC for not-core and not-maintenance stuff merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal spec-omission implemented but not currently specified
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@uhoreg @turt2live @benparsons @ara4n @richvdh @lukebarnard1