Discard deprecated builtin_type api
#11343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
approved these changes
Nov 4, 2021
| @@ -297,11 +297,6 @@ def class_type(self, self_type: Type) -> Type: | |||
| """Generate type of first argument of class methods from type of self.""" | |||
| raise NotImplementedError | |||
|
|
|||
| @abstractmethod | |||
| def builtin_type(self, fully_qualified_name: str) -> Instance: | |||
There was a problem hiding this comment.
It looks like this has been marked as deprecated since 2018, so it seems okay to remove it now.
hauntsaninja
added a commit
to hauntsaninja/gino-stubs
that referenced
this pull request
Jan 6, 2022
This was removed in python/mypy#11343
bryanforbes
added a commit
to bryanforbes/gino-stubs
that referenced
this pull request
Jan 19, 2022
* Remove use of deprecated builtin_type This was removed in python/mypy#11343 Co-authored-by: Bryan Forbes <[email protected]>
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
Related to python#6578. builtin_type could be totally replaced with named_type after python#11332. Also renames other builtin_type for consistency since all of them are actually calling named_type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #6578.
builtin_typecould be totally replaced withnamed_typeafter #11332. Also renames otherbuiltin_typefor consistency since all of them are actually callingnamed_type.