Use lookup_fully_qualified for SemanticAnalyzer.named_type #11332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
reviewed
Oct 14, 2021
There was a problem hiding this comment.
This looks great! The old behavior was clearly inconsistent.
It looks like this will be a breaking change to some plugins? If that's the case, we'll need to add a comment to #6617 about the change, and explain what needs to be done to support the new behavior.
mypy/semanal.py
Outdated
|
|
||
| def str_type(self) -> Instance: | ||
| return self.named_type('__builtins__.str') | ||
| return self.named_type('builtins.str') | ||
|
|
||
| def named_type(self, qualified_name: str, args: Optional[List[Type]] = None) -> Instance: |
There was a problem hiding this comment.
Rename qualified_name to fullname?
There was a problem hiding this comment.
It looks like this will be a breaking change to some plugins?
Yes. I think we should notify that we are using full name now and we support direct call on builtins module instead of __builtins__.
JukkaL
approved these changes
Oct 15, 2021
|
Can we close #6578 now? |
freundTech
added a commit
to freundTech/mypy
that referenced
this pull request
Oct 20, 2021
PrettyWood
added a commit
to PrettyWood/pydantic
that referenced
this pull request
Dec 24, 2021
Due to python/mypy#11332, mypy would crash because `__builtins__` is not part of `ctx.api` modules, `builtins` is
3 tasks
samuelcolvin
pushed a commit
to pydantic/pydantic
that referenced
this pull request
Dec 29, 2021
* build(deps): bump mypy from 0.920 to 0.930 * fix: avoid mypy plugin crash Due to python/mypy#11332, mypy would crash because `__builtins__` is not part of `ctx.api` modules, `builtins` is * fix tests
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
) Related to python#6578 This PR replaces lookup_qualified with lookup_fully_qualified for SemanticAnalyzer.named_type. Now it's consistant with the implementation of checker.named_type. This change also allows calling named_type without dunders.
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
Related to python#6578. builtin_type could be totally replaced with named_type after python#11332. Also renames other builtin_type for consistency since all of them are actually calling named_type.
squarebridges
pushed a commit
to nicejobinc/pydantic
that referenced
this pull request
Jun 24, 2022
* build(deps): bump mypy from 0.920 to 0.930 * fix: avoid mypy plugin crash Due to python/mypy#11332, mypy would crash because `__builtins__` is not part of `ctx.api` modules, `builtins` is * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related #6578
This PR replaces
lookup_qualifiedwithlookup_fully_qualifiedforSemanticAnalyzer.named_type. Now it's consistant with the implementation of checker.named_type. This change also allows calling named_type without dunders.Test Plan
Shouldn't affect any tests.