Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support POETRY_HOME for install #794

Merged
merged 2 commits into from
Oct 10, 2019

Conversation

dcramer
Copy link
Contributor

@dcramer dcramer commented Jan 13, 2019

Allow the POETRY_HOME environment variable to be passed during installation to change the default installation directory of ~/.poetry:

POETRY_HOME=/etc/poetry python get-poetry.py

Fixes #775

Allow the `POETRY_HOME` environment variable to be passed during installation to change the default installation directory of `~/.poetry`:

```
POETRY_HOME=/etc/poetry python get-poetry.py
```
@dcramer
Copy link
Contributor Author

dcramer commented Jan 13, 2019

Didn't look like there were any good existing test hooks for this but lmk if that's a concern. I did a manual QA and it appeared to work as expected.

@joshuarli
Copy link

@dcramer Oh nice, does this mean Sentry is going to be moving over to the new pyproject.toml PEP and along with that, potentially poetry and black? Well, I'm going to close getsentry/sentry#9026 anyways, I don't like nor use pipenv personally anymore.

@dcramer
Copy link
Contributor Author

dcramer commented Jan 14, 2019

@joshuarli migrated https://github.com/getsentry/zeus and some of my personal projects - not sure what we'll do for sentry core yet

@dvf
Copy link

dvf commented Jan 30, 2019

This is a welcome change. This is the last piece of the puzzle for us to ditch Pipenv for Poetry.

@evanpurkhiser
Copy link

Is there anything blocking this? Right now #775 (comment) works well.

@Peque
Copy link

Peque commented Jul 16, 2019

@sdispater Friendly ping for the second-most-upvoted MR. 😇

@brycedrennan brycedrennan added the kind/feature Feature requests/implementations label Aug 17, 2019
@kasteph
Copy link
Member

kasteph commented Sep 26, 2019

Thanks for the PR @dcramer 🍡 💫
This looks good to me -- can you fix the conflict before I merge this?

@dcramer
Copy link
Contributor Author

dcramer commented Sep 26, 2019

I'll leave it in someone elses court. Wont have time this week or next, and dont have a devenv setup for it right now. I imagine it's pretty easy if someone wants to tackle it.

@kasteph
Copy link
Member

kasteph commented Sep 26, 2019

@dcramer okay, thanks! I'll pick this up myself next week then.

Thanks again for your contribution 🙌

@kasteph kasteph self-assigned this Sep 26, 2019
@kasteph kasteph merged commit 2966ab1 into python-poetry:develop Oct 10, 2019
@dcramer dcramer deleted the feat/env-poetry-home branch October 10, 2019 20:40
sdispater added a commit that referenced this pull request Mar 20, 2020
* export: fix exporting extras sub-dependencies (#1294)

* Support POETRY_HOME for install (#794)

Allow the `POETRY_HOME` environment variable to be passed during installation to change the default installation directory of `~/.poetry`:

```
POETRY_HOME=/etc/poetry python get-poetry.py
```

* * check if relative filename is in excluded file list (#1459)

* * check if relative filename is in excluded file list
* removed find_excluded_files() method from wheel.py

* added test for excluding files in wheels

* creating an own test data folder, for testing excluding files by pyproject.toml

* use as_posix() to respect windows file path delimiters

* Exclude nested items (#784) (#1464)

* This PR impliments the feature request #784.

When a folder is explicit defined in `pyproject.toml` as excluded, all nested data, including subfolder, are excluded. It is no longer neccessary to use the glob `folder/**/*`

* use `Path` instead of `os.path.join` to create string for globbing

* try to fix linting error

* create glob pattern string by concatenating and not using Path

* using `os.path.isdir()`` for checking of explicit excluded name is a folder, because pathlib's `is_dir()` raises in exception under windows of name contains globing characters

* Remove nested data when wildcards where used.

Steps to do this are:
1. expand any wildcard used
2. if expanded path is a folder append  **/* and expand again

* fix linting

* only glob a second time if path is dir

* implement @sdispater 's suggestion for better readability

* fix glob for windows?

* On Windows, testing if a path with a glob is a directory will raise an OSError

* pathlibs  glob function doesn't return the correct case (https://bugs.python.org/issue26655). So switching back to  glob.glob()

* removing obsolete imports

* Update dependencies

* Deprecate allows-prereleases in favor of allow-prereleases for consistency

* Fix tests for Python 2.7

* Fix linting

* Fix linting

* Fix linting

* Fix typing import

* Correct a couple typos in get-poetry.py (#573)

* Docs: `self:update` changed to `self update` (#1588)

* Fix GitHub actions cache issues on develop (#1918)

* Fix Github actions cache issues

* Fix Github Actions cache issues (#1928)

* Add --source option to "poetry add" (#1912)

* Add --source option to 'poetry add'

* Add tests for 'poetry add --source'

* Merge master into develop (#2070)

* Fix Github actions cache issues (#1908)

* Fix case of `-f` flag

* Make it clearer what options to pass to `--format`

* fix (masonry.api): `get_requires_for_build_wheel` must return additional list of requirements for building a package, not listed in `pyproject.toml` and not dependencies for the package itself (#1875)

fix (tests): adopted tests

* Lazy Keyring intialization for PasswordManager (#1892)

* Fix Github Actions cache issues (#1928)

* Avoid nested quantifiers with overlapping character space on git url parsing (#1902 (#1913)

* fix (git): match for `\w` instead of `.` for getting user

* change (vcs.git): hold pattern of the regex parts in a dictionary to be consistent over all regexs

* new (vcs.git): test for `parse_url` and some fixes for the regex pattern

* new (vcs.git): test for `parse_url` with string that should fail

* fix (test.vcs.git): make flake8 happy

* fix: correct parsing of wheel version with regex. (#1932)

The previous regexp was only taking the first integer of the version number,
this presented problems when the major version number reached double digits.

Poetry would determine that the version of the dependency is '1', rather than,
ie: '14'. This caused failures to solve versions.

* Fix errors when using the --help option (#1910)

* Fix how repository credentials are retrieved from env vars (#1909)

# Conflicts:
#	poetry/utils/password_manager.py

* Fix downloading packages from Simplepypi (#1851)

* fix downloading packages from simplepypi

* unused code removed

* remove unused imports

* Upgrade dependencies for the 1.0.3 release (#1965)

* Bump version to 1.0.3 (#1966)

* Fix non-compliant Git URL matching

RFC 3986 § 2.3 permits more characters in a URL than were matched. This
corrects that, though there may be other deficiencies. This was a
regression from v1.0.2, where at least “.” was matched without error.

* Update README.md "Updating Poetry"

Currently the note in "Updating Poetry" is different from the one below in "Enable tab completion for Bash, Fish, or Zsh". This MR is to make them more consistent.

* init: change dev dependency prompt

* Fix CI issues (#2069)

Co-authored-by: brandonaut <[email protected]>
Co-authored-by: finswimmer <[email protected]>
Co-authored-by: Yannick PÉROUX <[email protected]>
Co-authored-by: Edward George <[email protected]>
Co-authored-by: Jan Škoda <[email protected]>
Co-authored-by: Andrew Marshall <[email protected]>
Co-authored-by: Andrew Selzer <[email protected]>
Co-authored-by: Andrii Maletskyi <[email protected]>

* pre-commit: replace isort mirror with isort upstream (#2118)

The isort pre-commit mirror has been deprecated. This change updates
configuration to use the upstream package repository instead of the
mirror.

* Add cache list command (#1187)

* Add poetry.locations.REPOSITORY_CACHE_DIR

The repository cache directory is used in multiple places in the
codebase. This change ensures that the value is reused.

* Add cache list command

This introduces a new cache sub-command that lists all available
caches.

Relates-to: #1162

Co-authored-by: Tom Milligan <[email protected]>
Co-authored-by: David Cramer <[email protected]>
Co-authored-by: finswimmer <[email protected]>
Co-authored-by: Kyle Altendorf <[email protected]>
Co-authored-by: Justin Mayer <[email protected]>
Co-authored-by: Yannick PÉROUX <[email protected]>
Co-authored-by: brandonaut <[email protected]>
Co-authored-by: Edward George <[email protected]>
Co-authored-by: Jan Škoda <[email protected]>
Co-authored-by: Andrew Marshall <[email protected]>
Co-authored-by: Andrew Selzer <[email protected]>
Co-authored-by: Andrii Maletskyi <[email protected]>
Co-authored-by: Arun Babu Neelicattu <[email protected]>
@glass-ships
Copy link

sorry to comment on a long since merged PR but I wasn't sure where to leave this...
is this feature supported in Windows as well? the documentation didn't provide a CMD example so it didn't seem immediately clear

@neersighted
Copy link
Member

Yes, the same environment variables are supported on Windows.

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Feature requests/implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants