-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
builder.sdist: remove setuptools import #24
Conversation
@sdispater was there a reason why we needed |
@abn from what I recall, distutils is deprecated and the |
This might mean we need to specify setuptools as a dependency, since otherwise pep517 builds are failing unless the |
It looks like we might need to handle the issue some other way. The issue can only be reproduced if pip is called with Using cached https://files.pythonhosted.org/packages/b7/70/5c287bd1e7c8c86a318755514e02c6d431335de541c43eef65d0fb5af955/poetry-core-1.0.0a5.tar.gz
Installing build dependencies: started
Installing build dependencies: finished with status 'done'
Getting requirements to build wheel: started
Getting requirements to build wheel: finished with status 'done'
Preparing wheel metadata: started
Preparing wheel metadata: finished with status 'done'
Skipping bdist_wheel for poetry-core, due to binaries being disabled for it.
Installing collected packages: poetry-core
Running setup.py install for poetry-core: started
Running setup.py install for poetry-core: finished with status 'error'
ERROR: Complete output from command /tmp/.venv/bin/python -u -c 'import setuptools, tokenize;__file__='"'"'/tmp/pip-install-uupqj3gr/poetry-core/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /tmp/pip-record-5zbpsbn6/install-record.txt --single-version-externally-managed --prefix /tmp/pip-build-env-2ulvu7lx/overlay --compile --install-headers /tmp/.venv/include/site/python3.7/poetry-core:
ERROR: Traceback (most recent call last):
File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'setuptools'
----------------------------------------
ERROR: Command "/tmp/.venv/bin/python -u -c 'import setuptools, tokenize;__file__='"'"'/tmp/pip-install-uupqj3gr/poetry-core/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /tmp/pip-record-5zbpsbn6/install-record.txt --single-version-externally-managed --prefix /tmp/pip-build-env-2ulvu7lx/overlay --compile --install-headers /tmp/.venv/include/site/python3.7/poetry-core" failed with error code 1 in /tmp/pip-install-uupqj3gr/poetry-core/ Related: https://discuss.python.org/t/pep-517-backend-bootstrapping/789/3 |
Closing this one for now, since the issue seems to be only present for an older version of pip in the environment. |
@sdispater Sorry for the hijack. |
@gweis i do not think
|
It appears we do not really need setuptools for now. The use of setuptools was preventing pip from installing poetry correctly for PEP-517 builds when
--no-binary :all:
was being used. Additionally, now we can install poetry-core from sdist as expected.Resolves: python-poetry/poetry#454