Skip to content

Commit

Permalink
Use setuptools instead of the distutils in the genarated setup.py
Browse files Browse the repository at this point in the history
  • Loading branch information
@sdispater
sdispater committed Oct 18, 2019
1 parent 7f5acc3 commit f759876
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion poetry/masonry/builders/sdist.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

SETUP = """\
# -*- coding: utf-8 -*-
from distutils.core import setup
from setuptools import setup
{before}
setup_kwargs = {{
Expand Down

1 comment on commit f759876

@altendky
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sdispater, relating to python-pendulum/pendulum#454, should this have added a setuptools dependency somewhere? My first guess is as an installation requirement of poetry itself. Or maybe poetry-core or... though I admittedly don't know the intent of poetry so if generated sdist are trying to be installable without poetry then they would need to change their pyproject.toml build-system build-backend and requires, but my guess is that isn't the intended situation.

Please sign in to comment.