Add guard helper functions from astroid #5122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Pierre-Sassoulas
added
the
Maintenance
| >>> from typing import TYPE_CHECKING | ||
| >>> if TYPE_CHECKING: | ||
| >>> from xyz import a | ||
| """ |
There was a problem hiding this comment.
I think keeping the docstring from astroid with the astroid parsing make sense too. (We just have to change the call from node.is_...() to is_...(node)). (I started to implement this this morning).
There was a problem hiding this comment.
Not sure it's necessary. They are only meant as examples anyway.
Pull Request Test Coverage Report for Build 1313933146
💛 - Coveralls |
Pierre-Sassoulas
approved these changes
Oct 6, 2021
cdce8p
force-pushed
the
add_guard-helper-functions
branch
from
a5b77c9 to
7f2aa57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup to the discussion here: #5107 (comment)
Add
is_typing_guardandis_sys_guardhelper functions topylint.checkers.utils.--
Deprecation astroid: pylint-dev/astroid#1202
/CC: @Pierre-Sassoulas @DanielNoord