Deprecate is_typing_guard and is_sys_guard
#1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
Maintenance
4 tasks
DanielNoord
reviewed
Oct 6, 2021
| @@ -2870,6 +2871,10 @@ def is_sys_guard(self) -> bool: | |||
| >>> node.is_sys_guard() | |||
| True | |||
| """ | |||
| warnings.warn( | |||
| "The 'is_sys_guard' function is deprecated and will be removed in astroid 3.0.0", | |||
There was a problem hiding this comment.
I would re-add these to pylint first and tell people about that in the warning. Give them a possibility to keep using the function, although from another place!
There was a problem hiding this comment.
Makes sense, good call.
cdce8p
reviewed
Oct 6, 2021
Co-authored-by: Marc Mueller <[email protected]>
|
I think referring to the changelog/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See pylint-dev/pylint#5107 (comment) for context.
Type of Changes
Related Issue
References #1199