Add static_assert() following a suggestion by @iwanders under PR #5334

pybind · Aug 25, 2024 · be3bafe · iwanders · Aug 25, 2024 · be3bafe
1 parent 9adbb61
commit be3bafe
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/include/pybind11/detail/struct_smart_holder.h b/include/pybind11/detail/struct_smart_holder.h
@@ -242,7 +242,9 @@ struct smart_holder {
                     std::string("smart_holder::extract_deleter() precondition failure (") + context
                     + ").");
             }
-            return std::unique_ptr<D>(new D(custom_deleter_ptr->deleter)); // D must be copyable.
+            static_assert(std::is_copy_constructible<D>::value,
+                          "Required for compatibility with smart_holder functionality.");
+            return std::unique_ptr<D>(new D(custom_deleter_ptr->deleter));
         }
         return nullptr;
     }